-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example data #58
Conversation
@smk78 - The majority of these data sets were purposely omitted during the initial move. The magnetic data directory was overlooked, but coordinate data and save states are only importable through SasView. Coordinate data readers and data structures should be here, but are not, as of yet: SasView/sasview#2656 Save states could also live here in the future, but that would require this package to load the data. |
Good point. I guess we need to think hard about what package loads what data but then we want to be able to list all of them in one place for the full SasView installer I gues? But for now this is a first step I guess? |
Ok. Noted. I'll take //coordinate_data and //saved_states out. |
So some thought will be needed about testdata_help.rst. This presently covers all our test/example data (ie, including those files not in or supported by sasdata). |
This looks like it should also be merged into 0.9 eventually so it will get bundled with 6.0? |
@krzywon probably needs to verify that this is now appropriate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better now. I have a small issue with the help file (it still mentions SasView specific files), but I don't think that should hold this PR up
When we release what example data will actually be included: I'm presuming not i). |
This PR updates the example data library in sasdata to match that in sasview main. This includes the supplied but not committed magnetic sans data from SasView/tutorials#13.
testdata_help.rst has also been revised accordingly.