Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the PDB, VTK, SLD, and OMF readers to sasdata package #2656

Open
krzywon opened this issue Oct 2, 2023 · 0 comments
Open

Move the PDB, VTK, SLD, and OMF readers to sasdata package #2656

krzywon opened this issue Oct 2, 2023 · 0 comments
Labels
Enhancement Feature requests and/or general improvements

Comments

@krzywon
Copy link
Contributor

krzywon commented Oct 2, 2023

Is your feature request related to a problem? Please describe.
This might be better as a discussion, but I think the various readers (PDBReader, etc.) and SLD profile classes (MagSLD, etc.) used by the generic scattering calculator would fit better in the sasdata package instead of sascalc. This would also help clean up sas_gen.py and allow outside groups a way to separate the readers from the calculations.

Describe the solution you'd like
Create new readers in sascalc.dataloader.readers for each of the types, move SLD data structure classes to data_info.py or a similar file, and add a separate loader class that returns SLD profiles instead of lists of Data1/2D.

@krzywon krzywon added the Enhancement Feature requests and/or general improvements label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements
Projects
None yet
Development

No branches or pull requests

1 participant