-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sasdata 8: Move example data to sasdata package #2637
Conversation
Question from @lucas-wilkins: will the new sasdata import work when the data is integrated with sasview? |
…iew/sasview into sasdata-8-move-example-data
Moving the files at CI time reminds me of #2421. Requiring multiple projects be checked out in a particular directory structure and then moving files between them at test and build time is an interesting symptom. |
Can I suggest you merge SasView/sasdata#58 first so you get the latest copy of the example data and updated testdata_help. |
I'm not sure I follow @smk78 comment? Presumably this PR removes the data files that are now already in sasdata main? This would be independent of any new data files being added to sasdata would it not? or am I misunderstanding the PR? Either way this needs to be merged into main as well as the 6.0.0_release branch somehow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was agreed at Tuesday's call that it was ready to merge but apparently nobody clicked the approve button. Doing so now
Description
Example data are removed from the sasview/sasview repo, and, instead, are copied from the sasdata build. This is the SasView corollary to SasView/sasdata#49 which is now merged.
How Has This Been Tested?
CI completes successfully
Review Checklist (please remove items if they don't apply):