Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sasdata 8: Move example data to sasdata package #2637

Merged
merged 12 commits into from
Feb 28, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Sep 21, 2023

Description

Example data are removed from the sasview/sasview repo, and, instead, are copied from the sasdata build. This is the SasView corollary to SasView/sasdata#49 which is now merged.

How Has This Been Tested?

CI completes successfully

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • User documentation is available and complete (if required)
  • Developers documentation is available and complete (if required)
  • The introduced changes comply with SasView license (BSD 3-Clause)

@krzywon
Copy link
Contributor Author

krzywon commented Sep 21, 2023

Question from @lucas-wilkins: will the new sasdata import work when the data is integrated with sasview?

@llimeht
Copy link
Contributor

llimeht commented Sep 24, 2023

Moving the files at CI time reminds me of #2421. Requiring multiple projects be checked out in a particular directory structure and then moving files between them at test and build time is an interesting symptom.

@wpotrzebowski wpotrzebowski added the Discuss At The Call Issues to be discussed at the fortnightly call label Sep 25, 2023
@wpotrzebowski wpotrzebowski changed the base branch from main to release_6.0.0 September 26, 2023 13:27
@wpotrzebowski wpotrzebowski removed the Discuss At The Call Issues to be discussed at the fortnightly call label Sep 26, 2023
@wpotrzebowski wpotrzebowski added Discuss At The Call Issues to be discussed at the fortnightly call and removed Discuss At The Call Issues to be discussed at the fortnightly call labels Oct 9, 2023
@butlerpd butlerpd added Discuss At The Call Issues to be discussed at the fortnightly call and removed Discuss At The Call Issues to be discussed at the fortnightly call labels Oct 23, 2023
@wpotrzebowski wpotrzebowski added Discuss At The Call Issues to be discussed at the fortnightly call and removed Discuss At The Call Issues to be discussed at the fortnightly call labels Nov 7, 2023
@butlerpd butlerpd added the Discuss At The Call Issues to be discussed at the fortnightly call label Nov 19, 2023
@wpotrzebowski wpotrzebowski added Discuss At The Call Issues to be discussed at the fortnightly call and removed Discuss At The Call Issues to be discussed at the fortnightly call labels Dec 3, 2023
@krzywon krzywon marked this pull request as draft December 5, 2023 14:10
@wpotrzebowski wpotrzebowski removed the Discuss At The Call Issues to be discussed at the fortnightly call label Dec 5, 2023
@smk78
Copy link
Contributor

smk78 commented Jan 18, 2024

Can I suggest you merge SasView/sasdata#58 first so you get the latest copy of the example data and updated testdata_help.

@butlerpd
Copy link
Member

butlerpd commented Feb 11, 2024

I'm not sure I follow @smk78 comment? Presumably this PR removes the data files that are now already in sasdata main? This would be independent of any new data files being added to sasdata would it not? or am I misunderstanding the PR?

Either way this needs to be merged into main as well as the 6.0.0_release branch somehow.

@butlerpd butlerpd added the Discuss At The Call Issues to be discussed at the fortnightly call label Feb 13, 2024
@butlerpd butlerpd removed the Discuss At The Call Issues to be discussed at the fortnightly call label Feb 13, 2024
@krzywon krzywon marked this pull request as ready for review February 22, 2024 21:32
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was agreed at Tuesday's call that it was ready to merge but apparently nobody clicked the approve button. Doing so now

@butlerpd butlerpd merged commit 19a97bd into release_6.0.0 Feb 28, 2024
36 checks passed
@butlerpd butlerpd deleted the sasdata-8-move-example-data branch February 28, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants