Produce error on prompt in non-tty environment.

[jhorbulyk]

Fixes #495

[codecov]

Codecov Report

Merging #891 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   93.23%   93.26%   +0.02%     
==========================================
  Files          26       26              
  Lines        1065     1069       +4     
  Branches       23       23              
==========================================
+ Hits          993      997       +4     
  Misses         72       72              

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a883e6...3e5df0f. Read the comment docs.

[SBoudrias]

The rest looks good to me, we should be able to merge and release quickly.

[jhorbulyk]

@SBoudrias Updated

[SBoudrias]

Perfect thanks! I'll make a new release soon.

[PetrSnobelt]

Hi, this PR causes the problem when used with when property, for example:

responses = await inquirer.prompt([{
          name: 'name',
          message: 'give a name to your app',
          default: '@kiwicom/fe-app',
          when: () => !flags.name,
        }])

We provide name in flags on CI, but it break our CI with "Error: Prompts can not be meaningfully rendered in non-TTY environments"

[jhorbulyk]

@PetrSnobelt Fixed in #896

[ruyadorno]

Hi @SBoudrias and @jhorbulyk sorry but unfortunately this change introduces a regression since stdin can be configured to something else other than just process.stdin:

Inquirer.js/packages/inquirer/lib/ui/baseUI.js

Line 70 in 2c521b7

var input = opt.input || process.stdin;

it completely broke ipt in your latest patch release since it actually leverages the configurable stdin in order to provide the functionality there 😭

[dan-barrett]

I'm somewhat confused as to where this issue stands. Looks like it was partly reverted in a future commit?

Can I explicitly configure inquirer to fail in non-tty environments or is that no longer possible? Having hard time finding documentation about it. Thanks!

[jhorbulyk]

I'm somewhat confused as to where this issue stands.

My understanding is that after the latest merged PRs, inquirer will fail in non-tty environments but only if:

• inquirer hasn't been configured to consume something other than stdin
• when() functions still cause the prompt to be rendered