Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inquirer and Caporal #45

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

jhorbulyk
Copy link
Contributor

  • Add option for more verbose logging on uncaught exceptions
  • Throw errors when attempting to render prompts in non-interactive
    environments.

Some updates were required in some downstream dependencies. There are PRs to fix these issues:

However, they haven't been merged and it's not clear when they will be merged. For the moment, I've just pointed to eio GitHub repos with commit IDs (as opposed to publishing shadow packages). For inquirer, the root of the GitHub repo isn't the location of the correct npm package.json, so I've solved this problem by adding a post install script to create a file which acts as a link. It's a dirty hack but it works...

Throw errors when attempting to render prompts in non-interactive
environments.
@jhorbulyk jhorbulyk requested review from kirill-levitskiy and A3a3e1 and removed request for kirill-levitskiy February 20, 2020 16:29
@jhorbulyk jhorbulyk merged commit 3985ced into release-2_1_0 Feb 21, 2020
@jhorbulyk jhorbulyk deleted the update-inquirer-and-caporal branch February 21, 2020 08:23
jhorbulyk added a commit that referenced this pull request Feb 24, 2020
* Add option for more verbose logging on uncaught exceptions (#45)
* Throw errors when attempting to render prompts in non-interactive
environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants