Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with non-tty checks and when. #896

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fix bug with non-tty checks and when. #896

merged 1 commit into from
Mar 4, 2020

Conversation

jhorbulyk
Copy link
Contributor

Fixes problem identified here: #891 (comment) by moving TTY check to immediately before question is asked.

@jhorbulyk jhorbulyk mentioned this pull request Mar 2, 2020
Merged
@mshima mshima mentioned this pull request Mar 4, 2020
Closed
@SBoudrias
Copy link
Owner

Thanks!

@SBoudrias SBoudrias merged commit ae97f39 into SBoudrias:master Mar 4, 2020
@jhorbulyk jhorbulyk mentioned this pull request Mar 4, 2020
Merged
@dotansimha
Copy link

Is there a way to bypass the new behaviour?
It breaks for me in dotansimha/graphql-code-generator#3571
We are running it in Jest test environment, and it seems like isTTY=false there (we have a mock for the inputs, and it worked before, but now it's failing because of this new check)

@mshima mshima mentioned this pull request Mar 9, 2020
Closed
jdoyle65 pushed a commit to jdoyle65/Inquirer.js that referenced this pull request Jan 19, 2021
@jhorbulyk
Fix bug with non-tty checks and when. (SBoudrias#896)
566395c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhorbulyk @SBoudrias @dotansimha