AAKaaS:1 check Component Versions #2023
Conversation
update from master
get latest from master
merge from master
Update from master
|
/it |
| CV *cv `json:"d"` | ||
| } | ||
|
|
||
| type cv struct { |
There was a problem hiding this comment.
Is it worth extracting cv and it's functions also to the abap package?
There was a problem hiding this comment.
cv is the acronym for "(software)component version" which are the (more or less) independent deployable units of an ABAP system.
Honestly I'm new to go and do not know where to place the coding best. As far as I got the cv struct is only used in this step without reuse in any of the others - that's why I have not extracted it. Anyway what I read so far about recommended directory structure I was a bit surprised there is no "internal" package. So what's the suggestion in this case? Should it be extracted even if there is only on step using it?
| description: Credential stored in Jenkins for Addon Assembly Kit as a Service System (AAKaaS) | ||
| type: jenkins | ||
| params: | ||
| - name: abapAddonAssemblyKitEndpoint |
There was a problem hiding this comment.
Is this a full qualified url or just the endpoint? For URL we typically call the parameter serverUrl.
There was a problem hiding this comment.
That's a bit tricky - what we need as input for this parameter is:
- In URI terms we just need scheme and authority - not the path
- in URL terms we just need the scheme, host and port - not the path,
- the WSDL term endpoint refers usually just to the URL including the path which we do not need as we have the path hard coded because every step uses a different path and we just wanted to have a single parameter instead of 7 different ones - especially as all 7 steps must be called in the same AAKaaS "system"
... so all did not match 100%...
| - STAGES | ||
| - STEPS | ||
| - GENERAL | ||
| - name: addonDescriptor |
There was a problem hiding this comment.
Just an idea, but can addonDescriptor and addonDescriptorFileName be combined that they both use the same format and thus we only need one parameter? It sounds as it contains the same information.
There was a problem hiding this comment.
As we plan an refactoring anyway I would take this as action item for an later PR
|
I just noticed that that only the golang implementation is part of this PR. The groovy part for this step is missing. IMO, this approach is fine - the groovy part can be done in a later PR. |
|
I added now the groovy part as well as all the insertions into general files (groovy, go, doku) which have to be done for every again and again :-/ |
Or in the last PR for all steps together |
|
/it |
If we follow the process in the most accurate way the content should match ;-) |
|
/it |
|
/it |
Changes
As discussed for PR #1973 -> Here the first of a series of PRs for the AAKaaS steps