Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrieveGitCoordinates - Improvement and Tests #13

Closed
wants to merge 3 commits into from
Closed

retrieveGitCoordinates - Improvement and Tests #13

wants to merge 3 commits into from

Conversation

o-liver
Copy link
Member

@o-liver o-liver commented Nov 20, 2017 •
edited
Loading

    • Better error message when no SCM present.
    • Store gitUrl and gitBranch in commonPipelineEnvironment (Needed for declarative pipelines).
  3. Tests:
    • Mocked job parameters.
    • Mocked parameters from scm.
    • Only git branch present.
    • Only git url present.
    • No scm present.
    • Check for git url and branch in commonPipelineEnvironment.
    • Documentation

@o-liver o-liver changed the title 'retrieveGitCoordinates' retrieveGitCoordinates - Improvement and Tests Nov 20, 2017
@o-liver o-liver force-pushed the retrieveGitCoordinates branch 6 times, most recently from 97fc5c5 to 471cb14 Compare November 21, 2017 13:38
@o-liver
Correct camelCase for 'valueGetMandatoryParameterTest'
5f46ce4
@o-liver
Move 'retrieveGitCoordinates' to GitUtils script and tests
3496a8f 
We expect more git utility functions, which is why GitUtils to collect
them makes sense.
For testing purposes the scm parameter is retrieved through a method.
If no scm is present the AbortException is caught to write a more
specific error message.
For declarative pipelines the git coordinates are stored in the
`commonPipelineEnvironment`.
The Les Furets framework is used to mock the commonPipelineEnvironment.
The tests mock the `echo` and `error` calls as a metaClass.
@o-liver o-liver force-pushed the retrieveGitCoordinates branch from 471cb14 to 3496a8f Compare November 22, 2017 14:33
@o-liver
Documentation for GitUtils
f948426 
Moved from Utils to GitUtils.
AbortException in case no SCM is present documented.
@o-liver
Copy link
Member Author

o-liver commented Nov 24, 2017

If PR#16 is merged, this PR is not necessary anymore and will be closed.

marcusholl
marcusholl requested changes Nov 24, 2017
View reviewed changes
Copy link
Member

@marcusholl marcusholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for "request changes": must not be merged currently since most probably superseded by PR 16.

@marcusholl
Copy link
Member

Superseded by PR #16. Approach of executing "central" pipelines changed. We now reference alway the payload repo in the pipeline job and load a central pipeline script from a stub pipeline script inside the payload repo. With that there is no need to find the git coordinates, neither from the job configuration of from the job parameters.

@marcusholl marcusholl closed this Dec 1, 2017
tiloKo added a commit to rosemarieB/jenkins-library that referenced this pull request Sep 17, 2020
@tiloKo
AAKaaS CheckCV step SAP#13
dd41c3e
DanielMieg added a commit that referenced this pull request Sep 17, 2020
@tiloKo @rosemarieB
@DanielMieg @CCFenner
AAKaaS:1 check Component Versions (#2023)
2a776ba 
* adding my steps

* messy step

* Update abapEnvironmentAssembly.go

* clean up

* change yaml

* corrections

* Update cloudFoundryDeploy.go

* update

* delete simulation step

* remove simulate

* Update PiperGoUtils.groovy

* Update PiperGoUtils.groovy

* Update CommonStepsTest.groovy

* add docu

* Update abapEnvironmentAssembly.md

* changes due to PR

* Update .gitignore

* b

* CV list

* Update abapEnvironmentAssembly.go

* testing with simulation

* Update abapEnvironmentAssembly.go

* remove simulation

* renaming

* Update mkdocs.yml

* moving service key to yaml and fixing code climate

* Update abapEnvironmentAssemblePackages.go

* Update abapEnvironmentAssemblePackages.go

* Update abapEnvironmentAssemblePackages.go

* Update abapEnvironmentAssemblePackages.go

* change input

* Update abapEnvironmentAssemblePackages.go

* change json tag

* fixed error handling

* documentation

* Update abapEnvironmentAssemblePackages.md

* Update abapEnvironmentAssemblePackages.md

* fixing code climate issues

* fixing code climate issues

* Update abapEnvironmentAssemblePackages.yaml

* fixing code climate issues

* Update abapEnvironmentAssemblePackages.yaml

* adding unittests

* adding unittests and improved logging

* yaml -> json

* change scope of cfServiceKeyName

* correct indentation

* Update CommonStepsTest.groovy

* maintain correct step order

* AAKaaS CheckCV step

* AAKaaS CheckCV step #2

* AAKaaS CheckCV step #3

* AAKaaS CheckCV step #4

* AAKaaS CheckCV step #5

* AAKaaS CheckCV step #6

* AAKaaS CheckCV step #7

* AAKaaS CheckCV step #8

* AAKaaS CheckCV step #9

* AAKaaS CheckCV step #10

* AAKaaS CheckCV step #11

* AAKaaS CheckCV step #12

* AAKaaS CheckCV step #13

Co-authored-by: rosemarieB <[email protected]>
Co-authored-by: Daniel Mieg <[email protected]>
Co-authored-by: Christopher Fenner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusholl marcusholl marcusholl requested changes

@OliverNocon OliverNocon OliverNocon approved these changes

@alejandraferreirovidal alejandraferreirovidal Awaiting requested review from alejandraferreirovidal

@kbarnold kbarnold Awaiting requested review from kbarnold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@o-liver @marcusholl @OliverNocon