Retrieve credentialsId from job definition #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusholl
requested review from
kbarnold,
alejandraferreirovidal and
o-liver
kbarnold
suggested changes
Nov 16, 2017
marcusholl
force-pushed
the
pr/gitutils
branch
from
0e913da to
bb5a00f
Compare
Closed
o-liver
requested changes
Nov 17, 2017
| #### Example | ||
|
|
||
| ```groovy | ||
| def gitUtils = new GitUtils() |
|
|
||
| ```groovy | ||
| def gitUtils = new GitUtils() | ||
| assert gitUtils.getMandatoryParameter('https://example.com/myGitRepo.git') == 'credentials-key' |
There was a problem hiding this comment.
Wrong function called. You mean getCredentialsId(), right?
There was a problem hiding this comment.
done, stupid CutNPaste error, thanks ...
marcusholl
force-pushed
the
pr/gitutils
branch
from
bb5a00f to
593c3a7
Compare
alejandraferreirovidal
suggested changes
Nov 17, 2017
|
|
||
| ## Constructors | ||
|
|
||
| ### Utils() |
src/com/sap/piper/GitUtils.groovy
Outdated
| * repository with the given url configured or there are no credentials | ||
| * maintained for that repository. | ||
| */ | ||
| def getCredentialsId(def repoUrl) { |
There was a problem hiding this comment.
def repoUrl --> def is not needed, and we don't use this syntax.
test/groovy/GitUtilsTest.groovy
Outdated
| assert new GitUtils().getCredentialsId(repo) == 'credId' | ||
| } | ||
|
|
||
| private static void prepareRemoteConfigs(def configs) { |
There was a problem hiding this comment.
def configs --> def is not needed, and we don't use this syntax.
Resolves the credentialsId for a given repo from the scm configuration in the job and from the job parameters. In case a matching repo is found in the configured scms and a credentialId is also provided as job parameter, the credentialsId from the job parameters is used. Depends on workflow-multibranch plugin since we make use of the scm variable provided by that plugin. With that change a new CredentialsUtils helper class in introduced in order to ensure clear scopes with the helpers instead of having all - basically unrelated - helper methods in one big helper class.
marcusholl
force-pushed
the
pr/gitutils
branch
from
593c3a7 to
aec9d09
Compare
should not be removed since, the tests needs it.
o-liver
reviewed
Nov 22, 2017
| } | ||
|
|
||
| /* | ||
| * Do not remove/inline this method. The tests relies on it. |
There was a problem hiding this comment.
[TYPO] ...The tests rely on it.
|
Must not be merged at the moment since it is most probably superseded by PR #16 . I cannot "request changes" since I initiated that PR. |
|
Superseded by PR #16 |
tiloKo
added a commit
to rosemarieB/jenkins-library
that referenced
this pull request
Sep 17, 2020
DanielMieg
added a commit
that referenced
this pull request
Sep 17, 2020
* adding my steps * messy step * Update abapEnvironmentAssembly.go * clean up * change yaml * corrections * Update cloudFoundryDeploy.go * update * delete simulation step * remove simulate * Update PiperGoUtils.groovy * Update PiperGoUtils.groovy * Update CommonStepsTest.groovy * add docu * Update abapEnvironmentAssembly.md * changes due to PR * Update .gitignore * b * CV list * Update abapEnvironmentAssembly.go * testing with simulation * Update abapEnvironmentAssembly.go * remove simulation * renaming * Update mkdocs.yml * moving service key to yaml and fixing code climate * Update abapEnvironmentAssemblePackages.go * Update abapEnvironmentAssemblePackages.go * Update abapEnvironmentAssemblePackages.go * Update abapEnvironmentAssemblePackages.go * change input * Update abapEnvironmentAssemblePackages.go * change json tag * fixed error handling * documentation * Update abapEnvironmentAssemblePackages.md * Update abapEnvironmentAssemblePackages.md * fixing code climate issues * fixing code climate issues * Update abapEnvironmentAssemblePackages.yaml * fixing code climate issues * Update abapEnvironmentAssemblePackages.yaml * adding unittests * adding unittests and improved logging * yaml -> json * change scope of cfServiceKeyName * correct indentation * Update CommonStepsTest.groovy * maintain correct step order * AAKaaS CheckCV step * AAKaaS CheckCV step #2 * AAKaaS CheckCV step #3 * AAKaaS CheckCV step #4 * AAKaaS CheckCV step #5 * AAKaaS CheckCV step #6 * AAKaaS CheckCV step #7 * AAKaaS CheckCV step #8 * AAKaaS CheckCV step #9 * AAKaaS CheckCV step #10 * AAKaaS CheckCV step #11 * AAKaaS CheckCV step #12 * AAKaaS CheckCV step #13 Co-authored-by: rosemarieB <[email protected]> Co-authored-by: Daniel Mieg <[email protected]> Co-authored-by: Christopher Fenner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.