Update URL to current SapMachine #5126

skateball · 2024-10-02T09:52:25Z

Hi colleagues,

11.0.2 in from Jan2019 := 5 years old
~~use the current version => 11.0.24 (update 25Oct2024: meanwhile the current version is 11.0.25)~~

Regards Christian@SapMachine

PS:
after some back and forth we have settled on java version 17.0.13

11.0.2 in from Jan2019 := 5 years old use the recent version => 11.0.24

cla-assistant · 2024-10-02T09:52:40Z

All committers have signed the CLA.

RealCLanger

Makes a lot of sense. I would prefer if we could even bump to 21.0.4 or at least 17.0.12...

skateball · 2024-10-02T15:22:07Z

Makes a lot of sense. I would prefer if we could even bump to 21.0.4 or at least 17.0.12...

sure, if the repo-owners agree the stable links
https://sap.github.io/SapMachine/latest/21/linux-x64/jre/
can be used

CCFenner · 2024-10-25T09:54:44Z

@akram8008 @dimaste consider adding yourself into https://github.com/SAP/jenkins-library/blob/master/.github/CODEOWNERS for the sources that are in your responsibility to get notification about open PRs.

meanwhile 11.0.25 is the latest version

skateball · 2024-10-25T16:27:29Z

meanwhile/since last week 11.0.25 is the latest version, wherefore i updated the PR.
independent from that you should consider (compare #5127 ) to switch to the stable link to the latest Long Term Release, that is 21. the Link would be
https://sap.github.io/SapMachine/latest/21/linux-x64/jre/
what I would do in another PR

now to use https://sap.github.io/SapMachine/latest/21/linux-x64/jre/

applied generated go code

RealCLanger · 2024-10-31T09:06:00Z

Looks even better now :)

o-liver · 2024-11-04T08:00:09Z

resources/metadata/whitesourceExecuteScan.yaml

@@ -255,7 +255,7 @@ spec:
          - PARAMETERS
          - STAGES
          - STEPS
-        default: "https://github.com/SAP/SapMachine/releases/download/sapmachine-11.0.2/sapmachine-jre-11.0.2_linux-x64_bin.tar.gz"
+        default: "https://sap.github.io/SapMachine/latest/21/linux-x64/jre/"


this does not look like a tar.gz file. Presumably the code will try and unpack whatever it fetches here. Did you test it?

Please test this once (locally with go run ...) to make sure the redirect happens and the JRE 21 is fine to execute this mend scan.

the given link is a HTTP '302 Temp Redirect' to the latest available release of SapMachine 21 linux-x64 JRE.
requested comment added to
https://github.com/skateball/jenkins-library/blob/master/resources/metadata/whitesourceExecuteScan.yaml#L250
description:
"URL used for downloading the Java Runtime Environment (JRE) required to run the WhiteSource Unified Agent. The URL is a HTTP 302 Temp Redirect to the always latest available SapMachine 21, linux-x64, JRE"

resources/metadata/whitesourceExecuteScan.yaml

o-liver · 2024-11-04T09:35:08Z

/go-it

o-liver

Please test this once (locally with go run ...) to make sure the redirect happens and the JRE 21 is fine to execute this mend scan.

aamotharald · 2024-11-04T10:24:40Z

Hi @o-liver ,

go run main.go whitesourceExecuteScan
does not come far enough..

any hint what I can do to test it?

o-liver · 2024-11-04T10:52:15Z

Hi @o-liver ,

go run main.go whitesourceExecuteScan does not come far enough..

any hint what I can do to test it?

I was hoping you had a whitesource project ready that you can test this with. Me neither. I will think of something...

o-liver

I'm trying to dismiss my review, does not seem to work easily anymore.

to speed this up

o-liver

looks good and tested

o-liver · 2024-11-08T08:28:39Z

/it-go

sonarqubecloud · 2024-11-08T08:28:45Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

…ix-fix * origin/master: (43 commits) fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178) Remove commit message from project-metadata.toml (SAP#5176) handle new naming strategy for Central Build stage name (SAP#5171) Update URL to current SapMachine (SAP#5126) checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170) docs: update pr template to include inner source update reminder (SAP#5169) handle error while fetching working directory (SAP#5168) Final round of adding quoting to prevent command injection (SAP#5167) feat: add build artifacts metadata for mtaBuild (SAP#5166) Fix more potential command injection via quoting (SAP#5164) Add identifier data to create uuid in events (SAP#5165) Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156) Fix: validate app name (SAP#5155) fix: command injection vulnerability (SAP#5161) fix deadlock and add more logging (SAP#5160) fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157) modify logging (SAP#5158) Detect script version 9 (SAP#5154) feat(vault): not allowing batch token revoke (SAP#4918) refactor(vault): Refactor vault package (SAP#5148) ...

* origin/master: (43 commits) fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178) Remove commit message from project-metadata.toml (SAP#5176) handle new naming strategy for Central Build stage name (SAP#5171) Update URL to current SapMachine (SAP#5126) checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170) docs: update pr template to include inner source update reminder (SAP#5169) handle error while fetching working directory (SAP#5168) Final round of adding quoting to prevent command injection (SAP#5167) feat: add build artifacts metadata for mtaBuild (SAP#5166) Fix more potential command injection via quoting (SAP#5164) Add identifier data to create uuid in events (SAP#5165) Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156) Fix: validate app name (SAP#5155) fix: command injection vulnerability (SAP#5161) fix deadlock and add more logging (SAP#5160) fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157) modify logging (SAP#5158) Detect script version 9 (SAP#5154) feat(vault): not allowing batch token revoke (SAP#4918) refactor(vault): Refactor vault package (SAP#5148) ...

…fig-fix * origin/master: (43 commits) fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178) Remove commit message from project-metadata.toml (SAP#5176) handle new naming strategy for Central Build stage name (SAP#5171) Update URL to current SapMachine (SAP#5126) checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170) docs: update pr template to include inner source update reminder (SAP#5169) handle error while fetching working directory (SAP#5168) Final round of adding quoting to prevent command injection (SAP#5167) feat: add build artifacts metadata for mtaBuild (SAP#5166) Fix more potential command injection via quoting (SAP#5164) Add identifier data to create uuid in events (SAP#5165) Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156) Fix: validate app name (SAP#5155) fix: command injection vulnerability (SAP#5161) fix deadlock and add more logging (SAP#5160) fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157) modify logging (SAP#5158) Detect script version 9 (SAP#5154) feat(vault): not allowing batch token revoke (SAP#4918) refactor(vault): Refactor vault package (SAP#5148) ...

Update URL to recent SapMachine

e28481a

11.0.2 in from Jan2019 := 5 years old use the recent version => 11.0.24

skateball requested a review from a team as a code owner October 2, 2024 09:52

skateball mentioned this pull request Oct 2, 2024

Exchange SapMachine 17.0.13 with SapMachine 17-latest #5127

Open

RealCLanger approved these changes Oct 2, 2024

View reviewed changes

CCFenner requested review from vijayanjay, dimaste and akram8008 October 25, 2024 09:48

11.0.24 to 25

f727baf

meanwhile 11.0.25 is the latest version

skateball and others added 3 commits October 25, 2024 18:29

update from 11.0.25 to stable 21 link

4c11074

now to use https://sap.github.io/SapMachine/latest/21/linux-x64/jre/

applied generated go code

6b76f73

LGTM - Merge pull request #1 from aamotharald/generate/go

c4861e7

applied generated go code

o-liver reviewed Nov 4, 2024

View reviewed changes

resources/metadata/whitesourceExecuteScan.yaml Outdated Show resolved Hide resolved

skateball and others added 2 commits November 4, 2024 10:28

Update whitesourceExecuteScan.yaml

dee5d14

Merge branch 'master' into master

1724823

o-liver requested changes Nov 4, 2024

View reviewed changes

Merge branch 'master' into master

c4abab1

o-liver self-requested a review November 7, 2024 08:03

Merge branch 'master' into master

13a005c

o-liver approved these changes Nov 7, 2024

View reviewed changes

o-liver self-requested a review November 7, 2024 08:04

o-liver requested changes Nov 7, 2024

View reviewed changes

skateball and others added 3 commits November 7, 2024 15:50

from 21-latest to 17.0.13

4245bd5

to speed this up

revert description

0f68a2f

generate for new url

0c10353

o-liver self-requested a review November 7, 2024 15:28

o-liver approved these changes Nov 8, 2024

View reviewed changes

Merge branch 'master' into master

6aa86c8

o-liver merged commit 1edf829 into SAP:master Nov 8, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update URL to current SapMachine #5126

Update URL to current SapMachine #5126

skateball commented Oct 2, 2024 •

edited by o-liver

Loading

cla-assistant bot commented Oct 2, 2024 •

edited

Loading

RealCLanger left a comment

skateball commented Oct 2, 2024 •

edited

Loading

CCFenner commented Oct 25, 2024

skateball commented Oct 25, 2024

RealCLanger commented Oct 31, 2024

o-liver Nov 4, 2024

o-liver Nov 4, 2024

skateball Nov 4, 2024

o-liver commented Nov 4, 2024

o-liver left a comment

aamotharald commented Nov 4, 2024

o-liver commented Nov 4, 2024

o-liver left a comment

o-liver left a comment

o-liver commented Nov 8, 2024

sonarqubecloud bot commented Nov 8, 2024

Update URL to current SapMachine #5126

Update URL to current SapMachine #5126

Conversation

skateball commented Oct 2, 2024 • edited by o-liver Loading

cla-assistant bot commented Oct 2, 2024 • edited Loading

RealCLanger left a comment

Choose a reason for hiding this comment

skateball commented Oct 2, 2024 • edited Loading

CCFenner commented Oct 25, 2024

skateball commented Oct 25, 2024

RealCLanger commented Oct 31, 2024

o-liver Nov 4, 2024

Choose a reason for hiding this comment

o-liver Nov 4, 2024

Choose a reason for hiding this comment

skateball Nov 4, 2024

Choose a reason for hiding this comment

o-liver commented Nov 4, 2024

o-liver left a comment

Choose a reason for hiding this comment

aamotharald commented Nov 4, 2024

o-liver commented Nov 4, 2024

o-liver left a comment

Choose a reason for hiding this comment

o-liver left a comment

Choose a reason for hiding this comment

o-liver commented Nov 8, 2024

sonarqubecloud bot commented Nov 8, 2024

Quality Gate passed

skateball commented Oct 2, 2024 •

edited by o-liver

Loading

cla-assistant bot commented Oct 2, 2024 •

edited

Loading

skateball commented Oct 2, 2024 •

edited

Loading