Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL to current SapMachine #5126

Merged
merged 13 commits into from
Nov 8, 2024
Merged

Update URL to current SapMachine #5126

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e28481a
Update URL to recent SapMachine
skateball Oct 2, 2024
f727baf
11.0.24 to 25
skateball Oct 25, 2024
4c11074
update from 11.0.25 to stable 21 link
skateball Oct 25, 2024
6b76f73
applied generated go code
aamotharald Oct 30, 2024
c4861e7
LGTM - Merge pull request #1 from aamotharald/generate/go
skateball Oct 30, 2024
dee5d14
Update whitesourceExecuteScan.yaml
skateball Nov 4, 2024
1724823
Merge branch 'master' into master
o-liver Nov 4, 2024
c4abab1
Merge branch 'master' into master
o-liver Nov 4, 2024
13a005c
Merge branch 'master' into master
o-liver Nov 7, 2024
4245bd5
from 21-latest to 17.0.13
skateball Nov 7, 2024
0f68a2f
revert description
skateball Nov 7, 2024
0c10353
generate for new url
o-liver Nov 7, 2024
6aa86c8
Merge branch 'master' into master
o-liver Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/whitesourceExecuteScan_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion resources/metadata/whitesourceExecuteScan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ spec:
- PARAMETERS
- STAGES
- STEPS
default: "https://github.com/SAP/SapMachine/releases/download/sapmachine-11.0.2/sapmachine-jre-11.0.2_linux-x64_bin.tar.gz"
default: "https://sap.github.io/SapMachine/latest/21/linux-x64/jre/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not look like a tar.gz file. Presumably the code will try and unpack whatever it fetches here. Did you test it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this once (locally with go run ...) to make sure the redirect happens and the JRE 21 is fine to execute this mend scan.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the given link is a HTTP '302 Temp Redirect' to the latest available release of SapMachine 21 linux-x64 JRE.
requested comment added to
https://github.com/skateball/jenkins-library/blob/master/resources/metadata/whitesourceExecuteScan.yaml#L250
description:
"URL used for downloading the Java Runtime Environment (JRE) required to run the WhiteSource Unified Agent. The URL is a HTTP 302 Temp Redirect to the always latest available SapMachine 21, linux-x64, JRE"

o-liver marked this conversation as resolved.
Show resolved Hide resolved
- name: licensingVulnerabilities
type: bool
description: "[NOT IMPLEMENTED] Whether license compliance is considered and reported as part of the assessment."
Expand Down
Loading