Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix handle new naming strategy for Central Build stage name if extension is used #5178

Merged
merged 11 commits into from
Nov 19, 2024
Merged

fix handle new naming strategy for Central Build stage name if extension is used #5178

merged 11 commits into from
Nov 19, 2024

Conversation

maxcask
Copy link
Member

@maxcask maxcask commented Nov 19, 2024 •
edited
Loading

Description

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@maxcask
Copy link
Member Author

maxcask commented Nov 19, 2024

/it-go

@maxcask maxcask changed the title fix for handle renaming Central Build stageN3ame to Build if extension is used fix for handle renaming Central Build stageName to Build if extension is used Nov 19, 2024
@maxcask maxcask changed the title fix for handle renaming Central Build stageName to Build if extension is used fix handle new naming strategy for Central Build stage name if extension is used Nov 19, 2024
D074360
D074360 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@D074360 D074360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcask maxcask marked this pull request as ready for review November 19, 2024 07:57
@maxcask maxcask requested a review from a team as a code owner November 19, 2024 07:57
@maxcask maxcask merged commit 10f535c into master Nov 19, 2024
12 checks passed
@maxcask maxcask deleted the feature/max_bo/HSPIPER-284 branch November 19, 2024 07:58
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Nov 20, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into kaniko-context-pref…
0442720 
…ix-fix

* origin/master: (43 commits)
  fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178)
  Remove commit message from project-metadata.toml (SAP#5176)
  handle new naming strategy for Central Build stage name (SAP#5171)
  Update URL to current SapMachine (SAP#5126)
  checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170)
  docs: update pr template to include inner source update reminder (SAP#5169)
  handle error while fetching working directory (SAP#5168)
  Final round of adding quoting to prevent command injection (SAP#5167)
  feat: add build artifacts metadata for mtaBuild (SAP#5166)
  Fix more potential command injection via quoting (SAP#5164)
  Add identifier data to create uuid in events (SAP#5165)
  Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156)
  Fix: validate app name (SAP#5155)
  fix: command injection vulnerability (SAP#5161)
  fix deadlock and add more logging (SAP#5160)
  fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157)
  modify logging (SAP#5158)
  Detect script version 9 (SAP#5154)
  feat(vault): not allowing batch token revoke (SAP#4918)
  refactor(vault): Refactor vault package (SAP#5148)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Nov 20, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into malwarescan-async-scan
d57756f 
* origin/master: (43 commits)
  fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178)
  Remove commit message from project-metadata.toml (SAP#5176)
  handle new naming strategy for Central Build stage name (SAP#5171)
  Update URL to current SapMachine (SAP#5126)
  checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170)
  docs: update pr template to include inner source update reminder (SAP#5169)
  handle error while fetching working directory (SAP#5168)
  Final round of adding quoting to prevent command injection (SAP#5167)
  feat: add build artifacts metadata for mtaBuild (SAP#5166)
  Fix more potential command injection via quoting (SAP#5164)
  Add identifier data to create uuid in events (SAP#5165)
  Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156)
  Fix: validate app name (SAP#5155)
  fix: command injection vulnerability (SAP#5161)
  fix deadlock and add more logging (SAP#5160)
  fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157)
  modify logging (SAP#5158)
  Detect script version 9 (SAP#5154)
  feat(vault): not allowing batch token revoke (SAP#4918)
  refactor(vault): Refactor vault package (SAP#5148)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Nov 20, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into whitesource-sbt-con…
a5babc7 
…fig-fix

* origin/master: (43 commits)
  fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178)
  Remove commit message from project-metadata.toml (SAP#5176)
  handle new naming strategy for Central Build stage name (SAP#5171)
  Update URL to current SapMachine (SAP#5126)
  checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170)
  docs: update pr template to include inner source update reminder (SAP#5169)
  handle error while fetching working directory (SAP#5168)
  Final round of adding quoting to prevent command injection (SAP#5167)
  feat: add build artifacts metadata for mtaBuild (SAP#5166)
  Fix more potential command injection via quoting (SAP#5164)
  Add identifier data to create uuid in events (SAP#5165)
  Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156)
  Fix: validate app name (SAP#5155)
  fix: command injection vulnerability (SAP#5161)
  fix deadlock and add more logging (SAP#5160)
  fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157)
  modify logging (SAP#5158)
  Detect script version 9 (SAP#5154)
  feat(vault): not allowing batch token revoke (SAP#4918)
  refactor(vault): Refactor vault package (SAP#5148)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D074360 D074360 D074360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcask @D074360 @Googlom