refactor(vault): Refactor vault package #5148
Merged
+541
−478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCFenner
changed the title
CCFenner
reviewed
Oct 22, 2024
Co-authored-by: Christopher Fenner <[email protected]>
Co-authored-by: Christopher Fenner <[email protected]>
Co-authored-by: Christopher Fenner <[email protected]>
|
|
/it-go |
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Nov 20, 2024
…ix-fix * origin/master: (43 commits) fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178) Remove commit message from project-metadata.toml (SAP#5176) handle new naming strategy for Central Build stage name (SAP#5171) Update URL to current SapMachine (SAP#5126) checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170) docs: update pr template to include inner source update reminder (SAP#5169) handle error while fetching working directory (SAP#5168) Final round of adding quoting to prevent command injection (SAP#5167) feat: add build artifacts metadata for mtaBuild (SAP#5166) Fix more potential command injection via quoting (SAP#5164) Add identifier data to create uuid in events (SAP#5165) Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156) Fix: validate app name (SAP#5155) fix: command injection vulnerability (SAP#5161) fix deadlock and add more logging (SAP#5160) fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157) modify logging (SAP#5158) Detect script version 9 (SAP#5154) feat(vault): not allowing batch token revoke (SAP#4918) refactor(vault): Refactor vault package (SAP#5148) ...
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Nov 20, 2024
* origin/master: (43 commits) fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178) Remove commit message from project-metadata.toml (SAP#5176) handle new naming strategy for Central Build stage name (SAP#5171) Update URL to current SapMachine (SAP#5126) checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170) docs: update pr template to include inner source update reminder (SAP#5169) handle error while fetching working directory (SAP#5168) Final round of adding quoting to prevent command injection (SAP#5167) feat: add build artifacts metadata for mtaBuild (SAP#5166) Fix more potential command injection via quoting (SAP#5164) Add identifier data to create uuid in events (SAP#5165) Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156) Fix: validate app name (SAP#5155) fix: command injection vulnerability (SAP#5161) fix deadlock and add more logging (SAP#5160) fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157) modify logging (SAP#5158) Detect script version 9 (SAP#5154) feat(vault): not allowing batch token revoke (SAP#4918) refactor(vault): Refactor vault package (SAP#5148) ...
maxatsap
added a commit
to maxatsap/jenkins-library
that referenced
this pull request
Nov 20, 2024
…fig-fix * origin/master: (43 commits) fix handle new naming strategy for Central Build stage name if extension is used (SAP#5178) Remove commit message from project-metadata.toml (SAP#5176) handle new naming strategy for Central Build stage name (SAP#5171) Update URL to current SapMachine (SAP#5126) checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (SAP#5170) docs: update pr template to include inner source update reminder (SAP#5169) handle error while fetching working directory (SAP#5168) Final round of adding quoting to prevent command injection (SAP#5167) feat: add build artifacts metadata for mtaBuild (SAP#5166) Fix more potential command injection via quoting (SAP#5164) Add identifier data to create uuid in events (SAP#5165) Update version of org.cyclonedx:cyclonedx-maven-plugin (SAP#5156) Fix: validate app name (SAP#5155) fix: command injection vulnerability (SAP#5161) fix deadlock and add more logging (SAP#5160) fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (SAP#5157) modify logging (SAP#5158) Detect script version 9 (SAP#5154) feat(vault): not allowing batch token revoke (SAP#4918) refactor(vault): Refactor vault package (SAP#5148) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main point of this refactor is to introduce token reneval by using Vault API recommended way.
Only
Clientcreation is refactored. Methods which actually make API calls are untouched.