-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (Core) remove DIALOG_CONFIG and DIALOG_REF and make DialogConfig and DialogRef injectable #4108
Conversation
✔️ Deploy preview for fundamental-ngx ready! 🔨 Explore the source changes: 7d4a6ac 🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-ngx/deploys/5fd8c15a8469770008304ec2 😎 Browse the preview: https://deploy-preview-4108--fundamental-ngx.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I don't remember what we agreed on, but this PR removes the injection tokens, so users will be forced to abandon them as well. This is a simple transition, so I think that's ok.
libs/core/src/lib/dialog/dialog-body/dialog-body.component.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please provide a link to the associated issue.
Closes #3903
Please provide a brief summary of this pull request.
BREAKING CHANGE:
removed DIALOG_CONFIG and DIALOG_REF and made DialogConfig and DialogRef classes injectable
Before:
Now:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md