Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Core) remove DIALOG_CONFIG and DIALOG_REF and make DialogConfig and DialogRef injectable #4108

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Dec 14, 2020

Please provide a link to the associated issue.

Closes #3903

Please provide a brief summary of this pull request.

BREAKING CHANGE:
removed DIALOG_CONFIG and DIALOG_REF and made DialogConfig and DialogRef classes injectable

Before:

constructor(
    @Inject(DIALOG_CONFIG) public dialogConfig: DialogConfig,
    @Inject(DIALOG_REF) private _dialogRef: DialogRef
)

Now:

constructor(
    public dialogConfig: DialogConfig,
    private _dialogRef: DialogRef
)

Please check whether the PR fulfills the following requirements

Documentation checklist:

@netlify
Copy link

netlify bot commented Dec 14, 2020

✔️ Deploy preview for fundamental-ngx ready!

🔨 Explore the source changes: 7d4a6ac

🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-ngx/deploys/5fd8c15a8469770008304ec2

😎 Browse the preview: https://deploy-preview-4108--fundamental-ngx.netlify.app

Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't remember what we agreed on, but this PR removes the injection tokens, so users will be forced to abandon them as well. This is a simple transition, so I think that's ok.

@InnaAtanasova InnaAtanasova changed the title [WIP] fix: (Core) remove DIALOG_CONFIG and DIALOG_REF and make DialogConfig and DialogRef injectable fix: (Core) remove DIALOG_CONFIG and DIALOG_REF and make DialogConfig and DialogRef injectable Dec 15, 2020
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@InnaAtanasova InnaAtanasova merged commit 356b3bb into master Dec 17, 2020
@InnaAtanasova InnaAtanasova deleted the fix/dialog-injection-token branch December 17, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog injection tokens
5 participants