-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (Core) add semantic icons to Message box and remove the close button #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Deploy preview for fundamental-ngx ready! 🔨 Explore the source changes: fc93cac 🔍 Inspect the deploy logs: https://app.netlify.com/sites/fundamental-ngx/deploys/5fdcf3fe6bf65d00084f412f 😎 Browse the preview: https://deploy-preview-4128--fundamental-ngx.netlify.app |
IlyaSurmay
approved these changes
Dec 17, 2020
InnaAtanasova
force-pushed
the
fix/message-box-updates
branch
from
December 17, 2020 13:51
489e6ae
to
6b86a29
Compare
salarenko
suggested changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- RIP close button. Do we have to remove this feature? It looks like it also should't be supported in the Dialog component, but we keep it there. It's weird that the design excluded such common element.
- Should we force user to put the icon element in the header by himself? Maybe we could put it always in the default message-box header template and show the user how to compose it by himself in the " Complex template" example?
libs/core/src/lib/message-box/message-box-semantic-icon/message-box-semantic-icon.component.ts
Outdated
Show resolved
Hide resolved
salarenko
suggested changes
Dec 18, 2020
libs/core/src/lib/message-box/message-box-semantic-icon/message-box-semantic-icon.component.ts
Show resolved
Hide resolved
libs/core/src/lib/message-box/message-box-header/message-box-header.component.html
Outdated
Show resolved
Hide resolved
libs/core/src/lib/message-box/message-box-header/message-box-header.component.ts
Outdated
Show resolved
Hide resolved
salarenko
approved these changes
Dec 18, 2020
InnaAtanasova
force-pushed
the
fix/message-box-updates
branch
from
December 18, 2020 14:47
ab1e76e
to
45df192
Compare
JKMarkowski
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Closes #3887
Please provide a brief summary of this pull request.
BREAKING CHANGE:
MessageBoxCloseIconComponent
component is removedPlease check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md