You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently Dialog is using DIALOG_CONFIG and DIALOG_REF injections token for providing config and ref dependencies. Having additional tokens makes it harder for the user to implement the Dialog (user needs to know and remember about the tokens).
The proposition is to remove DIALOG_CONFIG and DIALOG_REF and make DialogConfig and DialogRef injectable. This will result in user having to write this:
constructor(
public dialogConfig: DialogConfig,
public dialogRef: DialogRef
) { }
instead of:
constructor(
@Inject(DIALOG_CONFIG) public dialogConfig: DialogConfig,
@Inject(DIALOG_REF) public dialogRef: DialogRef
) { }
2h - document; keep both approaches for now and deprecate the current
The text was updated successfully, but these errors were encountered:
Is this a bug, enhancement, or feature request?
enhancement
Briefly describe your proposal.
Currently Dialog is using
DIALOG_CONFIG
andDIALOG_REF
injections token for providing config and ref dependencies. Having additional tokens makes it harder for the user to implement the Dialog (user needs to know and remember about the tokens).The proposition is to remove
DIALOG_CONFIG
andDIALOG_REF
and makeDialogConfig
andDialogRef
injectable. This will result in user having to write this:instead of:
2h - document; keep both approaches for now and deprecate the current
The text was updated successfully, but these errors were encountered: