skylark: Prefer @drake//tools/skylark over //tools/skylark
#9845
Conversation
There was a problem hiding this comment.
+@jwnimmer-tri for review, please.
Reviewable status: all discussions resolved, platform LGTM missing
|
I think it would make more sense to kick this to on-call review. The point of me punting on it was to reduce my distractions. |
|
Do we (want to) have a Bazel style guide to start to document all these workarounds? I can't keep track of them all anymore. |
|
I think some conventions probably deserve a styleguide, but for this (functional) rule I think a linter would be more effective. |
|
Certainly more effective, but it would nice for humans to have something to go by as well. |
There was a problem hiding this comment.
-@jwnimmer-tri for review
+@sammy-tri for both reviews (low priority, so whenevs).
Will make a separate issue on how to best handle this in the future.
Reviewable status: all discussions resolved, LGTM missing from assignee jwnimmer-tri, platform LGTM missing
There was a problem hiding this comment.
Reviewed 40 of 40 files at r1.
Reviewable status:complete! all discussions resolved, platform LGTM from [sammy-tri]
For more information, see: - bazelbuild/bazel#3115 - RobotLocomotion#8700
EricCousineau-TRI
force-pushed
the
issue/8732
branch
from
a0f1cda to
086e4cb
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:
For more information, see:
@and@workspacenameconsidered different repositories bazelbuild/bazel#3115common/proto/BUILD.bazelinstall rules are sensitive to whether they use//tools:drake.bzlvs.//tools/skylark:drake_cc.bzl#8700Resolves #8732
This change is