Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/proto/BUILD.bazel install rules are sensitive to whether they use //tools:drake.bzl vs. //tools/skylark:drake_cc.bzl #8700

Closed
EricCousineau-TRI opened this issue Apr 27, 2018 · 1 comment
Closed

common/proto/BUILD.bazel install rules are sensitive to whether they use //tools:drake.bzl vs. //tools/skylark:drake_cc.bzl #8700

EricCousineau-TRI opened this issue Apr 27, 2018 · 1 comment

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Apr 27, 2018 •
edited
Loading

In #8699, for the drake_cc_* macros, I had changed //tools:drake.bzl (which is just a forwarding thing from #6996?) to //tools/skylark:drake_cc.bzl; however, CI and my bazel test //... both fail with the following error:

ERROR: .../drake/master/drake/common/proto/BUILD.bazel:97:1: in deps attribute of drake_installed_headers rule //common/proto:rpc_pipe_temp_directory.installed_headers: '//common:essential.installed_headers' does not have mandatory providers: 'DrakeCc'. Since this rule was created by the macro 'drake_cc_library', the error might have been caused by the macro implementation in .../drake/master/drake/tools/skylark/drake_cc.bzl:261:20
ERROR: Analysis of target '//common/proto:call_matlab.installed_headers' failed; build aborted: Analysis of target '//common/proto:rpc_pipe_temp_directory.installed_headers' failed; build aborted

'tis quite mysterious.

@jwnimmer-tri @jamiesnape Have y'all seen this already?
(And can I ask who should own this one?)

Here's the offending commit:
EricCousineau-TRI@385e0b9
@jwnimmer-tri
Copy link
Collaborator

Yes, that is bazelbuild/bazel#3115. You have to use @drake. In #8582, I replaced some of the drake.bzl forwarders with drake_cc.bzl, but not all. At some point, we should go back and replace them all.

EricCousineau-TRI added a commit to EricCousineau-TRI/drake that referenced this issue Oct 29, 2018
@EricCousineau-TRI
skylark: Prefer @drake//tools/skylark over //tools/skylark
a0f1cda 
For more information, see:
- bazelbuild/bazel#3115
- RobotLocomotion#8700
@EricCousineau-TRI EricCousineau-TRI mentioned this issue Oct 29, 2018
Merged
EricCousineau-TRI added a commit to EricCousineau-TRI/drake that referenced this issue Oct 29, 2018
@EricCousineau-TRI
skylark: Prefer @drake//tools/skylark over //tools/skylark
086e4cb 
For more information, see:
- bazelbuild/bazel#3115
- RobotLocomotion#8700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwnimmer-tri @EricCousineau-TRI