mkdoc: Work around a problematic deprecation_example header dep #15069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: high
status: single reviewer ok
jwnimmer-tri
force-pushed
the
bazel-410-fixes
branch
from
b5f844d to
4637024
Compare
|
+@EricCousineau-TRI for both reviews, please. I've confirmed that with both Bazel 4.0.0 and Bazel 4.1.0, the contents of the generated |
There was a problem hiding this comment.
'tis quite a wiggy behavior!
Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/skylark/pybind.bzl, line 340 at r1 (raw file):
# Remove headers that are duplicated as both a virtual include path # and a source path. We'll to use the virtual include path, since
nit grammar missing verb btw "We'll ? to use"
Perhaps the to is redundant?
|
tools/skylark/pybind.bzl, line 340 at r1 (raw file): Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Demoting this to BTW. |
When collecting the list of package headers, in the case of the deprecation example (which has no package library) we were ending up with two different copies of the header being passed to mkdoc: bazel-out/k8-opt/bin/bindings/pydrake/common/_virtual_includes/deprecation_example_class/drake/bindings/pydrake/common/test/deprecation_example/example_class.h bindings/pydrake/common/test/deprecation_example/example_class.h The first one is the path we want -- the one used while compiling, and thus the one with a matching -I flag. The second one is a correct dependency, but not used for compiling, so does not have any -I flag, so breaks mkdoc. Here, we customize our skylark header collection to ignore the second file.
jwnimmer-tri
force-pushed
the
bazel-410-fixes
branch
from
4637024 to
124abb2
Compare
|
Best guess, bazelbuild/bazel@e3b7e17 is what bit us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting the list of package headers, in the case of the deprecation example (which has no package library) we were ending up with two different copies of the header being passed to mkdoc:
The first one is the path we want -- the one used while compiling, and thus the one with a matching
-Iflag. The second one is a correct dependency, but not used for compiling, so does not have any matching-Iflag, so breaks mkdoc.Here, we customize our skylark header collection to ignore the second file.
(Note that #15066 and #15068 are also required for Bazel 4.1 builds to succeed.)
This change is