-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semi-automated Python binding generation tool #14878
Add semi-automated Python binding generation tool #14878
Conversation
Co-authored-by: Eric Cousineau <[email protected]> Co-authored-by: Joe Snyder <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)
a discussion (no related file):
Should it worry me that just adding a header that includes generated lcm headers fails because it can't find those headers? Do I need to augment some build rule somewhere?
diff --git a/tools/autopybind/bindings_to_generate.yaml b/tools/autopybind/bindings_to_generate.yaml
index bbee6e93e1..ba174c0328 100644
--- a/tools/autopybind/bindings_to_generate.yaml
+++ b/tools/autopybind/bindings_to_generate.yaml
@@ -151,3 +151,23 @@ files:
DepthRange: {}
DepthRenderCamera: {}
RenderEngine: {}
+ # This stanza fails to build because generated headers for
+ # lcm structs are not found.
+ # "drake/manipulation/kuka_iiwa/iiwa_command_receiver.h":
+ # namespaces:
+ # drake:
+ # namespaces:
+ # manipulation:
+ # namespaces:
+ # kuka_iiwa:
+ # classes:
+ # IiwaCommandReceiver: {}
For now, I'm doing experiments in a branch that contains this PR and a revert of #15069.
Try adding drake/tools/autopybind/BUILD.bazel Line 20 in bd47934
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)
a discussion (no related file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
Should it worry me that just adding a header that includes generated lcm headers fails because it can't find those headers? Do I need to augment some build rule somewhere?
diff --git a/tools/autopybind/bindings_to_generate.yaml b/tools/autopybind/bindings_to_generate.yaml index bbee6e93e1..ba174c0328 100644 --- a/tools/autopybind/bindings_to_generate.yaml +++ b/tools/autopybind/bindings_to_generate.yaml @@ -151,3 +151,23 @@ files: DepthRange: {} DepthRenderCamera: {} RenderEngine: {} + # This stanza fails to build because generated headers for + # lcm structs are not found. + # "drake/manipulation/kuka_iiwa/iiwa_command_receiver.h": + # namespaces: + # drake: + # namespaces: + # manipulation: + # namespaces: + # kuka_iiwa: + # classes: + # IiwaCommandReceiver: {}
For now, I'm doing experiments in a branch that contains this PR and a revert of #15069.
The remedy recommended above (add a dependency) worked.
Moved to #15205. |
Relates #7889, #14265, and autopybind11/autopybind11#140 (gitlab.kitware.com).
Needs CI update.
This change is