Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semi-automated Python binding generation tool #14878

Closed
wants to merge 1 commit into from
Closed

Add semi-automated Python binding generation tool #14878

wants to merge 1 commit into from

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Apr 8, 2021

Relates #7889, #14265, and autopybind11/autopybind11#140 (gitlab.kitware.com).

Needs CI update.


This change is Reviewable

Co-authored-by: Eric Cousineau <[email protected]>
Co-authored-by: Joe Snyder <[email protected]>
@jamiesnape
Copy link
Contributor Author

Error in fail: Header external/eigen/include/_usr_include_eigen3/Eigen/Cholesky lacks a plausible include path. Looks like #15069 has changed some behavior. FYI @jwnimmer-tri (though I am sure the issue is here, not in #15069).

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)

a discussion (no related file):
Should it worry me that just adding a header that includes generated lcm headers fails because it can't find those headers? Do I need to augment some build rule somewhere?

diff --git a/tools/autopybind/bindings_to_generate.yaml b/tools/autopybind/bindings_to_generate.yaml
index bbee6e93e1..ba174c0328 100644
--- a/tools/autopybind/bindings_to_generate.yaml
+++ b/tools/autopybind/bindings_to_generate.yaml
@@ -151,3 +151,23 @@ files:
                   DepthRange: {}
                   DepthRenderCamera: {}
                   RenderEngine: {}
+  # This stanza fails to build because generated headers for
+  # lcm structs are not found.
+  # "drake/manipulation/kuka_iiwa/iiwa_command_receiver.h":
+  #   namespaces:
+  #     drake:
+  #       namespaces:
+  #         manipulation:
+  #           namespaces:
+  #             kuka_iiwa:
+  #               classes:
+  #                 IiwaCommandReceiver: {}

For now, I'm doing experiments in a branch that contains this PR and a revert of #15069.


@jamiesnape
Copy link
Contributor Author

Try adding //lcmtypes:lcmtypes_drake_cc here and see if it unblocks you:

"//tools/install/libdrake:drake_headers",

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)

a discussion (no related file):

Previously, rpoyner-tri (Rick Poyner (rico)) wrote…

Should it worry me that just adding a header that includes generated lcm headers fails because it can't find those headers? Do I need to augment some build rule somewhere?

diff --git a/tools/autopybind/bindings_to_generate.yaml b/tools/autopybind/bindings_to_generate.yaml
index bbee6e93e1..ba174c0328 100644
--- a/tools/autopybind/bindings_to_generate.yaml
+++ b/tools/autopybind/bindings_to_generate.yaml
@@ -151,3 +151,23 @@ files:
                   DepthRange: {}
                   DepthRenderCamera: {}
                   RenderEngine: {}
+  # This stanza fails to build because generated headers for
+  # lcm structs are not found.
+  # "drake/manipulation/kuka_iiwa/iiwa_command_receiver.h":
+  #   namespaces:
+  #     drake:
+  #       namespaces:
+  #         manipulation:
+  #           namespaces:
+  #             kuka_iiwa:
+  #               classes:
+  #                 IiwaCommandReceiver: {}

For now, I'm doing experiments in a branch that contains this PR and a revert of #15069.

The remedy recommended above (add a dependency) worked.


@jamiesnape jamiesnape marked this pull request as ready for review June 17, 2021 14:33
@jamiesnape jamiesnape mentioned this pull request Jun 21, 2021
@jamiesnape
Copy link
Contributor Author

Moved to #15205.

@jamiesnape jamiesnape closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants