geometry: Fix set of installed headers to be consistent #15066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installed headers are parsed by mkdoc to create pydrake docstrings. When mkdoc scans an installed header that includes an uninstalled header, it results in a build failure, so we must be careful to only install headers that can be parsed. This is also cleaner for our users.
jwnimmer-tri
added
priority: high
status: single reviewer ok
|
Have you seen #14792? |
|
Nope, I had not. This PR definitely relates to that issue. The changes there sound like better solutions, but this PR is sufficient to unblock me, and doesn't seem like it makes things worse? +@SeanCurtis-TRI for both reviews, please. |
This was referenced May 21, 2021
|
Alternatively, I can submit that solution directly in the next 30 minutes. We could swap roles and you could review it. Preference? |
|
Either one is fine with me. |
|
I'm about 10 minutes out from submitting a PR. |
|
Can you confirm that #15070 unblocks you? |
|
Replaced by #15070. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installed headers are parsed by mkdoc to create pydrake docstrings.
When mkdoc scans an installed header that includes an uninstalled header, it results in a build failure, so we must be careful to only install headers that can be parsed. This is also cleaner for our users.
This ends up being a blocker for the bazel 4.1 upgrade.
This change is