Add pandas to prerequisites #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@jwnimmer-tri for review. CC @m-chaturvedi. |
|
Given #61, we are not keeping the dependency lists 1:1 identical anyway. Since the only reason the Drake commit is breaking drake-external-examples is because the PR was buggy, what do you think about fixing the bug in Drake instead of adding a heavy new dependency here? |
|
I would prefer that, but I do not want CI to be red for too long. We can leave this to sit while @m-chaturvedi investigates. |
|
I support minimizing red. We should never be afraid to revert, either. |
|
True. If you want to revert, I am fine by that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required since RobotLocomotion/drake@426a52a. Ideally, I do not feel the code in question here should really have to run, but this gets everything green/blue again for now.
This change is