Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pybind11 coverage" #12819

Closed
wants to merge 1 commit into from
Closed

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Mar 5, 2020

Reverts #12040. Relates RobotLocomotion/drake-external-examples#165.

CC @jwnimmer-tri.

Dear @m-chaturvedi,

The on-call build cop believes that your PR #12040 may have
broken one or more of Drake's continuous integration builds [1]. It is
possible to break a build even if your PR passed continuous integration
pre-merge because additional platforms are tested post-merge.

The specific build failures under investigation are:

Therefore, the build cop has created this revert PR and started a complete
post-merge build to determine whether your PR was in fact the cause of the
problem. If that build passes, this revert PR will be merged 60 minutes from
now. You can then fix the problem at your leisure, and send a new PR to
reinstate your change.

If you believe your original PR did not actually break the build, please
explain on this thread.

If you believe you can fix the break promptly in lieu of a revert, please
explain on this thread, and send a PR to the build cop for review ASAP.

If you believe your original PR definitely did break the build and should be
reverted, please review and LGTM this PR. This allows the build cop to merge
without waiting for CI results.

For advice on how to handle a build cop revert, see [2].

Thanks!
Your Friendly On-call Build Cop

[1] CI Production Dashboard: https://drake-jenkins.csail.mit.edu/view/Production/
[2] https://drake.mit.edu/buildcop.html#workflow-for-handling-a-build-cop-revert


This change is Reviewable

@m-chaturvedi
Copy link
Contributor

m-chaturvedi commented Mar 5, 2020

I could verify locally by uninstalling python3-pandas, that:
bazel build //bindings/pydrake:generate_pybind_documentation_header
fails to build on master due to lack of pandas.

and that it builds on #12818.

@jamiesnape
Copy link
Contributor Author

So #12818 is the fix forward?

@m-chaturvedi
Copy link
Contributor

Yes, if the lack of python3-pandas is the only problem, it is a fix.

@jamiesnape jamiesnape closed this Mar 5, 2020
@jamiesnape jamiesnape deleted the revert-12040-pybind11_coverage branch March 5, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants