-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls] Add Emerge Snapshot Tests #4529
Conversation
…s tester for emerge
…esterTests file in main xcodeproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so good! Just a few small naming suggestions 😊
But also, is there a reason to not run this on every PR? I mean, not every commit is doing a UI change but we do run it on every PR for Android (see here) and its kind of nice, IMO 😇
Or if we can't do that... it might be nice to have another command that is simlar to the "test all" one but only for snapshots? 🤷♂️ Thoughts?
Co-authored-by: Josh Holtz <[email protected]>
Co-authored-by: Josh Holtz <[email protected]>
This PR:
PaywallTester
.SnapshotPreviews
package to the test target.PaywallsTester
to Emerge.Shoutout to @noahsmartin for all the help!