Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paywalls] Add Emerge Snapshot Tests #4529

Merged
merged 12 commits into from
Dec 3, 2024
Merged

[Paywalls] Add Emerge Snapshot Tests #4529

merged 12 commits into from
Dec 3, 2024

Conversation

MarkVillacampa
Copy link
Member

@MarkVillacampa MarkVillacampa commented Dec 2, 2024

This PR:

  • Adds a test target to PaywallTester.
  • Adds Emerge's SnapshotPreviews package to the test target.
  • Adds Emerge's Fastlane plugin and a new lane which uploads PaywallsTester to Emerge.
  • Adds a CircleCI job to run the lane.

Shoutout to @noahsmartin for all the help!

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good! Just a few small naming suggestions 😊

But also, is there a reason to not run this on every PR? I mean, not every commit is doing a UI change but we do run it on every PR for Android (see here) and its kind of nice, IMO 😇

Or if we can't do that... it might be nice to have another command that is simlar to the "test all" one but only for snapshots? 🤷‍♂️ Thoughts?

.circleci/config.yml Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
@MarkVillacampa MarkVillacampa merged commit 33a718c into main Dec 3, 2024
8 checks passed
@MarkVillacampa MarkVillacampa deleted the emerge-dev branch December 3, 2024 20:36
@vegaro vegaro mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants