Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing preview #4406

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

noahsmartin
Copy link
Contributor

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

This preview was crashing causing an error when running snapshot tests

Description

Fixed the missing environment object that caused the crash

@noahsmartin noahsmartin mentioned this pull request Oct 24, 2024
2 tasks
@MarkVillacampa MarkVillacampa changed the base branch from main to emerge-dev December 2, 2024 15:56
@MarkVillacampa MarkVillacampa merged commit 87237e4 into RevenueCat:emerge-dev Dec 2, 2024
@noahsmartin noahsmartin deleted the fixPreview branch December 2, 2024 17:49
MarkVillacampa added a commit that referenced this pull request Dec 3, 2024
* Add preview test target (#4405)

* Fix crashing preview (#4406)

* Build test app (#4407)

* Add emerge_purchases_ui_snapshot_tests circleci job

* Enable PAYWALL_COMPONENTS compilation condition when building paywalls tester for emerge

* fix fastfile

* Set emerge snapshot dependency up to next major and include PaywallsTesterTests file in main xcodeproj

* dont run emerge snapshot tests on every PR

* Update .circleci/config.yml

Co-authored-by: Josh Holtz <[email protected]>

* Update fastlane/Fastfile

Co-authored-by: Josh Holtz <[email protected]>

* run snapshot tests on every PR

* fix ci

---------

Co-authored-by: Noah Martin <[email protected]>
Co-authored-by: Josh Holtz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants