fix(ESSNTL-4714): fix display name unwanted reset on sort #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1846 +/- ##
=======================================
Coverage 65.15% 65.15%
=======================================
Files 136 136
Lines 3421 3421
Branches 1025 1025
=======================================
Hits 2229 2229
Misses 1192 1192
☔ View full report in Codecov by Sentry. |
|
I ran into this issue while testing When trying to make another video with more detail, I actually couldnt repro the issue. I also couldnt repro the bug on master for some reason. Going to keep testing |
|
Works! LGTM |
Fewwy
approved these changes
Apr 27, 2023
gkarat
pushed a commit
that referenced
this pull request
Apr 27, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-27) ### Bug Fixes * **ESSNTL-4714:** fix display name unwanted reset on sort ([#1846](#1846)) ([38ff4c4](38ff4c4)) * **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d)) * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) * RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a)) ### Reverts * Revert Inventory groups back end mocks (#1845) ([e633f77](e633f77)), closes [#1845](#1845) [#1793](#1793) * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
|
🎉 This PR is included in version 1.14.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a random issue on the Inventory table. When you enter a string into the display name filter and remove the filter one char at a time in the input element and then sort by any column, the display name filter gets reset.
To test the issue happens randomly, but this way seems more frequent, so please play with the filter and sorting more: