fix(InventroyTable): Add activeFiltersConfig to prop cache to trigger refresh #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1838 +/- ##
==========================================
- Coverage 64.92% 64.89% -0.03%
==========================================
Files 135 135
Lines 3418 3418
Branches 1025 1025
==========================================
- Hits 2219 2218 -1
- Misses 1199 1200 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
/retest |
bastilian
force-pushed
the
fix_prop_cache
branch
from
6628ee6 to
d974c49
Compare
bastilian
force-pushed
the
fix_prop_cache
branch
from
d974c49 to
9ec8573
Compare
gkarat
pushed a commit
that referenced
this pull request
Apr 21, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-21) ### Bug Fixes * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat
pushed a commit
that referenced
this pull request
Apr 21, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-21) ### Bug Fixes * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat
pushed a commit
that referenced
this pull request
Apr 21, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-21) ### Bug Fixes * **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d)) * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat
pushed a commit
that referenced
this pull request
Apr 25, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-25) ### Bug Fixes * **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d)) * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) * RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a)) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat
pushed a commit
that referenced
this pull request
Apr 26, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-26) ### Bug Fixes * **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d)) * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) * RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a)) ### Reverts * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat
pushed a commit
that referenced
this pull request
Apr 27, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-27) ### Bug Fixes * **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d)) * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) * RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a)) ### Reverts * Revert Inventory groups back end mocks (#1845) ([e633f77](e633f77)), closes [#1845](#1845) [#1793](#1793) * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat
pushed a commit
that referenced
this pull request
Apr 27, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-27) ### Bug Fixes * **ESSNTL-4714:** fix display name unwanted reset on sort ([#1846](#1846)) ([38ff4c4](38ff4c4)) * **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d)) * **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb)) * **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a)) * **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e)) * RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a)) ### Reverts * Revert Inventory groups back end mocks (#1845) ([e633f77](e633f77)), closes [#1845](#1845) [#1793](#1793) * Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
|
🎉 This PR is included in version 1.14.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compliance adds filters via the
activeFiltersConfigprop and not thecustomFiltersprop and does not use the redux store to keep active filters and does therefore not trigger a refresh properly and only the first filter change in compliance would trigger a refresh, or if a filter is used coming from the inventory, like tags.How to test:
The last step would fail without this change.