Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-383: Fix typo in the tooltip when insights client is not reporting #1842

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

strider
Copy link
Contributor

@strider strider commented Apr 25, 2023

This PR is just fixing a small typo.

s/Registration Assitant/Registration Assistant/

…rting

`s/Registration Assitant/Registration Assistant/`

Signed-off-by: Gael Chamoulaud (Strider) <[email protected]>
@strider strider requested a review from a team as a code owner April 25, 2023 17:41
Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @strider!

@AsToNlele
Copy link
Contributor

/retest

Copy link

@thearifismail thearifismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@bastilian bastilian merged commit 01b6c8a into RedHatInsights:master Apr 25, 2023
gkarat pushed a commit that referenced this pull request Apr 25, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-25)

### Bug Fixes

* **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d))
* **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb))
* **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a))
* **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e))
* RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a))

### Reverts

* Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
@strider strider deleted the RHINENG-383 branch April 25, 2023 18:57
gkarat pushed a commit that referenced this pull request Apr 26, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-26)

### Bug Fixes

* **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d))
* **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb))
* **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a))
* **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e))
* RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a))

### Reverts

* Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat pushed a commit that referenced this pull request Apr 27, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-27)

### Bug Fixes

* **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d))
* **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb))
* **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a))
* **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e))
* RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a))

### Reverts

* Revert Inventory groups back end mocks (#1845) ([e633f77](e633f77)), closes [#1845](#1845) [#1793](#1793)
* Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
gkarat pushed a commit that referenced this pull request Apr 27, 2023
## [1.14.8](v1.14.7...v1.14.8) (2023-04-27)

### Bug Fixes

* **ESSNTL-4714:** fix display name unwanted reset on sort ([#1846](#1846)) ([38ff4c4](38ff4c4))
* **InventoryTable:** Pass on activeFiltersConfig properly ([#1840](#1840)) ([a8cec1d](a8cec1d))
* **InventroyTable:** Add activeFiltersConfig to prop cache to trigger refresh ([#1838](#1838)) ([82b3acb](82b3acb))
* **LastSeenFilter:** Add edge cases for new filter ([f53155a](f53155a))
* **LastSeenFilter:** Fixes Validators and adds test ([#1837](#1837)) ([f4d6e6e](f4d6e6e))
* RHINENG-383 - Fix typo in the tooltip when insights client is not reporting ([#1842](#1842)) ([01b6c8a](01b6c8a))

### Reverts

* Revert Inventory groups back end mocks (#1845) ([e633f77](e633f77)), closes [#1845](#1845) [#1793](#1793)
* Revert "ESSNTL(4056): Adds checks against edge cases for last seen filter (#1787)" ([1f0b70c](1f0b70c)), closes [#1787](#1787)
@gkarat
Copy link
Contributor

gkarat commented Apr 28, 2023

🎉 This PR is included in version 1.14.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants