-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: samples #1350
docs: samples #1350
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +83 B (0%) Total Size: 223 kB
ℹ️ View Unchanged
|
I don't think this needs to be comprehensive. the only blockers on this should be things like:
but, like .. "we should also do this for xyz element" can be a follow up pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://deploy-preview-1350--red-hat-design-system.netlify.app/elements/accordion/style/#theme
Color Palette isn't clickable here in Chrome 120.0.6099.199:
Doesn't display at all in Safari 17.2.1 :
And is weirdly cropped in Firefox 115.6.0esr (64-bit)
@zeroedin not necessarily all sample images, but at least the ones that make the most sense. |
46e3f1c
to
5445670
Compare
the anatomy sample component is at the MVP level. if that's the only blocker, slap a |
@bennypowers honestly, I feel like the Sample Component has gone beyond the original intention. Don't get me wrong, it's looking pretty cool with all the features, but I think it changes the context of the design sections, like the Style tab. We don't want to replace ALL images, since images still have their use in these sections. For example, if you're wanting to see all the different Sizes of the Audio Player, it looks "fine" (aside from the last one breaking out of the container): But, on Mobile, you lose the visual since ALL of the Audio Player samples become "mobile friendly": We want the image to show ALL the sizes/options, and not have the visual representation / Sample Component react live to the browser or container width. Note: the little purple tooltips are also wonky on mobile, but that's a separate topic I feel like the true use of the Sample Component lives on the Code and Overview tabs, where we'd want to show a live example, and not on design sections where we'd want to highlight specific features (that retain their context across devices). For example, on mobile, the Configuration section is using an image still, and it doesn't lose it's context—you can still see all the config options visually: Hopefully that makes sense. This isn't a blocker anyway. Maybe we take this out of the Caterpie release, and fast follow with it since it's just docs. |
yup, makes sense to me. TL;DR: I'm happy to save this for chancey, with modifications
I spun out #1413 with all the "by-the-way" fixes from this PR |
Do we want to hold on |
Superceeded mostly by #1465 |
What I did
{% sample %}
paired shortcode