Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: last minute polish for caterpie #1413

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

bennypowers
Copy link
Member

  • remove duplicated code from base layout
  • move uxdot- elements to their own dir
  • correct usage of rh-card variants in docs and demos
  • format some source code in audio player
  • format the README

What I did

  1. spun off some general fixes and improvement from docs: samples #1350 into a separate PR

- remove duplicated code from base layout
- move uxdot- elements to their own dir
- correct usage of rh-card variants in docs and demos
- format some source code in audio player
- format the README
Copy link

changeset-bot bot commented Jan 11, 2024

⚠️ No Changeset found

Latest commit: 65656c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 65656c4
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/659f8f0e639dd30008f0662d
😎 Deploy Preview https://deploy-preview-1413--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bennypowers bennypowers mentioned this pull request Jan 11, 2024
Copy link
Contributor

Size Change: 0 B

Total Size: 223 kB

ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 3.52 kB
./elements/rh-accordion/rh-accordion-panel.js 1.47 kB
./elements/rh-accordion/rh-accordion.js 3.52 kB
./elements/rh-alert/rh-alert.js 4.4 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.85 kB
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.43 kB
./elements/rh-audio-player/rh-audio-player.js 14.2 kB
./elements/rh-audio-player/rh-cue.js 2 kB
./elements/rh-audio-player/rh-transcript.js 2.94 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.91 kB
./elements/rh-badge/rh-badge.js 1 kB
./elements/rh-blockquote/rh-blockquote.js 1.94 kB
./elements/rh-button/rh-button.js 4.38 kB
./elements/rh-card/rh-card.js 1.94 kB
./elements/rh-code-block/rh-code-block.js 1.25 kB
./elements/rh-cta/rh-cta.js 4.56 kB
./elements/rh-dialog/rh-dialog.js 4.79 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.18 kB
./elements/rh-footer/rh-footer-social-link.js 1.35 kB
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.08 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.25 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.57 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 572 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.39 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.46 kB
./elements/rh-spinner/rh-spinner.js 1.61 kB
./elements/rh-stat/rh-stat.js 2.24 kB
./elements/rh-subnav/rh-subnav.js 2.83 kB
./elements/rh-surface/rh-surface.js 1.02 kB
./elements/rh-table/rh-sort-button.js 1.44 kB
./elements/rh-table/rh-table.js 2.9 kB
./elements/rh-tabs/rh-tab-panel.js 1.16 kB
./elements/rh-tabs/rh-tab.js 2.8 kB
./elements/rh-tabs/rh-tabs.js 4.54 kB
./elements/rh-tag/rh-tag.js 1.96 kB
./elements/rh-tile/rh-tile-group.js 1.76 kB
./elements/rh-tile/rh-tile.js 4.68 kB
./elements/rh-timestamp/rh-timestamp.js 976 B
./elements/rh-tooltip/rh-tooltip.js 2.24 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 1.99 kB
./lib/context/event.js 598 B
./lib/context/headings/consumer.js 711 B
./lib/context/headings/controller.js 1.14 kB
./lib/context/headings/provider.js 1.23 kB
./lib/DirController.js 569 B
./lib/elements/rh-context-demo/rh-context-demo.js 1.14 kB
./lib/elements/rh-context-picker/rh-context-picker.js 2.41 kB
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 856 B
./rhds.min.js 81.6 kB

compressed-size-action

@bennypowers bennypowers requested a review from markcaron January 11, 2024 07:19
@bennypowers bennypowers enabled auto-merge (squash) January 11, 2024 07:19
@hellogreg hellogreg requested a review from zeroedin January 11, 2024 15:14
Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luminous Galaxies Twinkle Mysteriously 🪐 👾

@bennypowers bennypowers merged commit 5264b3e into main Jan 11, 2024
8 checks passed
@bennypowers bennypowers deleted the docs/caterpie-polish branch January 11, 2024 15:45
Copy link
Collaborator

@markcaron markcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Mark (too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

3 participants