docs: layout css rewrite, and adding uxdot-components and more... #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zeroedin
changed the title
|
Size Change: +9 B (0%) Total Size: 251 kB
ℹ️ View Unchanged
|
23 tasks
|
How bad would the conflicts be if you tried to merge or rebase off #1420? |
I wouldn't think too terrible. I haven't touched that much in |
bennypowers
reviewed
Jun 4, 2024
bennypowers
approved these changes
Jun 9, 2024
bennypowers
dismissed
nikkimk’s stale review
wishing Nikki well in her new position, we shouldn't require her review on this PR
marionnegp
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
rh-*components where prudent.docs/styles/styles.css,docs/styles/typography.css,docs/styles/reset.cssuxdot-*componentsuxdot-masthead,uxdot-sidenav,uxdot-feedback,uxdot-hero,uxdot-best-practices.uxdot-headeruxdot-sidenavis now generated from data (sorta) seeeleventy.config.cjs, not thrilled with this, but it works for now, needs improved. Intent was to reduce overhead of html in that template. Ideally the data would be normalized prior to hitting the interface of the component. [feat]<rh-sidenav>element #1329_includesdirectory to make it more grokkable. Specifically the child folderlayoutsto split global from page layouts and snippets (aka partials which might be a better name for it).rh-table[docs] Element Props and Attrs sections should be tables #1448TODO:
reset.css,typography.css,styles.cssand using@importpros/cons.uxdot-example. what are some improvements we can make there?/about/*get-started/*foundations/*tokens/*uxdot-sidenavto the trigger button and make it function.uxdot-sidenavassets/color/oldassets/get-started/dialogassets/get-started/icon-librariesassets/get-started/product-logo-libraryassets/grid/grid-responsive-large, mobile-landscape, mobile-portrait, tabletassets/home/workflow-icon.svgassets/navigation-foundations/assets/promo-banner/assets/search-bar/assets/spacing/4px.svg-> 80px.svgassets/tokens/tokens.cssassets/typography/typography-quote.svgassets/cem.cssassets/close-icon.svgassets/demos.cssassets/info-icon.svgassets/padlock-locked.svgrh-tilein places whererh-carditems are acting as navigation items. eg<nav class="grid"><rh-tile>...</nav>foundations/typographytable. Using old PFE values. I've removed them and added a TODO comment for now..gridusage across pages, should this become a shared utility class or custom element (no shadowdom?)uxdot-tocthat can switch to details element on small viewportsFigma spacing spec: https://www.figma.com/proto/cU0GFIoCz6EU5v3B3byw0U/Docs-overhaul---template-spacing-and-typography?page-id=1%3A2&type=design&node-id=1-1454&viewport=102%2C129%2C1&t=NETho8DWjiwj1qpp-1&scaling=scale-down&mode=design
Move these task items to a fast follow PR:
rh-tile. ref: [bug]<rh-tile>z-index issue with::afterlink #1469urlfilter on links https://www.11ty.dev/docs/plugins/html-base/Testing Instructions
Notes to Reviewers
Lots has changed yet little has changed. Content should be pretty close to 1:1 other then maybe some adjustments to layout where it makes the presentation a bit nicer, such as a 3 column grid, or items placed in
rh-tileorrh-cardwhere we can dogfood those components. Additionally tables have been converted all to userh-table.Tasks:
uxdot-sidenavneeds accessibility review