refactor: reorganize and rename settings #1307

KobeW50 · 2023-09-24T09:25:08Z

Closes #1296
Closes #1297

I renamed some of the options, partially based off of palms comment in #1296 (comment)

Huge thanks to @validcube for compiling and testing (bec i have no clue what im doing)

KobeW50 · 2023-09-24T09:27:51Z

assets/i18n/en_US.json

@@ -241,15 +240,15 @@
        "importPatchesHint": "Import patches selection from a JSON file",
        "importedPatches": "Patches selection imported",

-        "resetStoredPatchesLabel": "Reset patches",
+        "resetStoredPatchesLabel": "Reset patches selection",


Im not sure if it should be "Reset patches selection" or "Reset patch selection" (same question for the similar options)

Maybe "Reset selection of patches"?

I think that sounds clunky. If this is changed the other options need to be changed too for consistency (Ie: "Export selection of patches")

What do you think @PalmDevs

Technically, it should be patch selections, since it is multiple selections of patches. This can be combined with options which would result in something along the lines of:

Reset patch selections and options

Patches selection just doesn't sound right in my opinion.

Okay, ill make these changes today

lib/ui/widgets/settingsView/settings_advanced_section.dart

validcube

🥞 LGTM

KobeW50 · 2023-09-24T09:57:39Z

Should the 'Allow experimental patches' be renamed to something like "Ignore version restraints"?

The current title is generic

PalmDevs · 2023-09-24T10:00:58Z

Noticed some inconsistencies:

Regenerate keystore (description)

- used to sign the app
+ used to sign apps

Sources & API URL (description)
Remove custom as you can also reset the setting which means it is not always custom.
```
- custom
```
Allow changing patch selection (title)
```
- patch selection
+ patches selection
```
Import keystore & Export keystore (description)
Add the in front of the word keystore. This will imply there can only be one keystore at a time.
```
- keystore
+ the keystore
```

Show universal patches (description)
Change to:

Display all apps and universal patches (may slow down the app)

Allow experimental patches (description)
Change Enable to Allow
```
- Enable
+ Allow
```

PalmDevs · 2023-09-24T10:08:51Z

Should the 'Allow experimental patches' be renamed to something like "Ignore version restraints"?

The current title is generic

What does CLI say for the --force flag?

KobeW50 · 2023-09-24T10:11:51Z

Import keystore & Export keystore (description)
Add the in front of the word keystore. This will imply there can only be one keystore at a time.
- keystore
+ the keystore

Even for importing a keystore? Saying "Import the keystore used to sign apps" makes it sounds like there is only one keystore in existence. I think "a keystore" is more appropriate in this context

PalmDevs · 2023-09-24T10:13:20Z

Even for importing a keystore? Saying "Import the keystore used to sign apps" makes it sounds like there is only one keystore in existence. I think "a keystore" is more appropriate in this context

Good point, use a instead.

#1307 (comment)

KobeW50 · 2023-09-24T10:21:42Z

Should the 'Allow experimental patches' be renamed to something like "Ignore version restraints"?

The current title is generic

What does CLI say for the --force flag?

Im not sure, and idk how to find out

PalmDevs · 2023-09-24T10:33:14Z

Here it is. This is unfortunately too nerdy/advanced for an average user to understand however. Any suggestions based on this?

KobeW50 · 2023-09-24T14:26:56Z

Thanks. I cant think of anything except that "force" may sound like the user doesn't have a choice

KobeW50 · 2023-09-24T20:10:43Z

I asked on discord. osum, ushie, and taku discussed it and came up with these

Bypass version compatibility checks
Bypass version check
Ignore version restrictions
Ignore version constraints
Ignore incompatible version

I dont think it matters too much. All these are better than the current title, but more context will be needed in the description anyway

PalmDevs · 2023-09-25T00:22:47Z

I asked on discord. osum, ushie, and taku discussed it and came up with these

Bypass version compatibility checks

Bypass version check

Ignore version restrictions

Ignore version constraints

Ignore incompatible version

I dont think it matters too much. All these are better than the current title, but more context will be needed in the description anyway

5 is out of the question, it's not necessarily incompatible at times. 1 is unfortunately too long. However, combinations of 2 and 3 or 4 might work.

Bypass version restrictions
Bypass version constraints

oSumAtrIX · 2023-09-25T00:24:40Z

How about negating and calling the switch "Version compatibility check" and having it on by default?

PalmDevs · 2023-09-25T00:33:03Z

How about negating and calling the switch "Version compatibility check" and having it on by default?

Good idea. It makes you feel like you're turning off a feature.

changed a file name and string

KobeW50 · 2023-09-26T03:21:29Z

Should I rename all strings relating to the Info section to refer to it as the Debug section instead so it is easier to understand the code? And should I do the same while renaming the "experimental patches" to "Version compatibility check"?

(edit: I reflected these changes locally and can push them. I just don't know how to revert a push or commit so I'm waiting for a "go-ahead")

Also, I'm not sure how to change the default value for the Version compatibility check toggle so ill need someone to help me out. I asked validcube on discord. Will see if he's down

Lastly, do I need to build the apk after the final changes are made to test? Some of you may know that I cant figure flutter out 😅

KobeW50 · 2023-09-26T04:05:52Z

Show universal patches (description)
Change to:

Display all apps and universal patches (may slow down the app)

This implies that the app will be slower in general, but only the app list loading speed is affected

changes all references to the experimental patches support to "version compatibility check"

Ushie · 2023-10-13T20:03:52Z

@PalmDevs

2023-10-13.23-03-02.mp4

KobeW50 · 2023-10-13T20:14:52Z

We ended up keeping the 'Reset patch options' in the import/export section because it is closely related to the 'Reset patch selections'.

PalmDevs

Needs a few string changes and documentation changes.

assets/i18n/en_US.json

docs/2_4_settings.md

KobeW50 · 2023-10-13T21:06:53Z

@PalmDevs I'm not sure if it sends notifications for code review replies (sorry for the extra ping if it did)

PalmDevs · 2023-10-13T21:27:22Z

@KobeW50 Press change any "Patch selections" to "Patch selection", the pluralized form of selection is not needed. Thank you! 🙏

KobeW50 · 2023-10-13T21:33:49Z

@KobeW50 Press change any "Patch selections" to "Patch selection", the pluralized form of selection is not needed. Thank you! 🙏

What about what was discussed here? Are we considering all selections as one collective selection? I think what you and oSum said earlier is the correct wording

When we are referring to the selection of all apps, it should be patch selections.

PalmDevs · 2023-10-13T22:05:47Z

What about what was discussed here? Are we considering all selections as one collective selection? I think what you and oSum said earlier is the correct wording

When we are referring to the selection of all apps, it should be patch selections.

Yes, we'll be considering every selection as one collective selection.

KobeW50 · 2023-10-13T22:12:43Z

Yes, we'll be considering every selection as one collective selection.

It seems confusing to use the same term to refer to a single selection and the collective of multiple selections.

When Patch selections is used, the user immediately knows that it is referring to all selections. I don't see a downside to using plural selections if the context allows it.

oSumAtrIX · 2023-10-13T22:13:38Z

If you can say Selection of patches instead of Selections of patches then you should also be able to say Patch selection.

KobeW50 · 2023-10-15T00:38:50Z

There are still instances of "ReVanced Patches" in the consent dialog, but as far as I know, this dialog only appears the first time the app is opened, so the source and API will always be from ReVanced.

KobeW50 · 2023-10-15T04:22:40Z

I believe this is ready to be merged.

PalmDevs

A few changes I've missed (sorry!) and we're good.

assets/i18n/en_US.json

PalmDevs

LGTM!

reorganize and rename settings

688979c

validcube changed the title ~~reorganize and rename settings~~ refactor: reorganize and rename settings Sep 24, 2023

This was linked to issues Sep 24, 2023

feat: Improve manager settings order #1296

Closed

Inconsistent settings option name and description #1297

Closed

KobeW50 commented Sep 24, 2023

View reviewed changes

lib/ui/widgets/settingsView/settings_advanced_section.dart Outdated Show resolved Hide resolved

KobeW50 and others added 3 commits September 24, 2023 05:34

Small consistency fix

629fef2

refactor: string

b647c0a

refactor(i18n): string

ea97d9f

validcube requested a review from Ushie September 24, 2023 09:37

validcube approved these changes Sep 24, 2023

View reviewed changes

validcube requested review from PalmDevs and removed request for Ushie September 24, 2023 09:37

Update en_US.json

0a5783c

#1307 (comment)

rename InfoSection to DebugSection

f891ff6

changed a file name and string

rename ExperimentalPatches to VersionCompatibilityCheck

48310e8

changes all references to the experimental patches support to "version compatibility check"

KobeW50 and others added 5 commits October 13, 2023 18:43

use new toggle names in patcher logs

395e821

Merge branch 'dev' into pr/KobeW50/1307-2

5687731

docs: reflect new settings order (and small changes)

2c370f6

refactor and reorganize en_US.json

b292c09

docs: fix incorrect order

9b68156

Ushie approved these changes Oct 13, 2023

View reviewed changes

docs: typo

52a47af

PalmDevs suggested changes Oct 13, 2023

View reviewed changes

refactor strings for requested changes

55d195c

singularize "selections"

8096231

change "ReVanced Patches" to "patches"

2ee0c90

KobeW50 requested a review from PalmDevs October 15, 2023 04:21

KobeW50 requested a review from oSumAtrIX October 15, 2023 04:22

requested changes

5cfb989

PalmDevs suggested changes Oct 15, 2023

View reviewed changes

assets/i18n/en_US.json Outdated Show resolved Hide resolved

assets/i18n/en_US.json Outdated Show resolved Hide resolved

requested changes regarding "keystore"

8f33519

PalmDevs approved these changes Oct 15, 2023

View reviewed changes

Merge branch 'dev' into dev

02a76e1

validcube merged commit 196d9fe into ReVanced:dev Oct 15, 2023

KobeW50 mentioned this pull request Oct 15, 2023

'Version compatibility check' toggle does opposite of intended behavior #1386

Closed

4 tasks

refactor: reorganize and rename settings #1307

refactor: reorganize and rename settings #1307

Conversation

KobeW50 commented Sep 24, 2023 • edited Loading

KobeW50 Sep 24, 2023

Choose a reason for hiding this comment

Ushie Oct 4, 2023

Choose a reason for hiding this comment

KobeW50 Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Ushie Oct 4, 2023

Choose a reason for hiding this comment

PalmDevs Oct 10, 2023

Choose a reason for hiding this comment

KobeW50 Oct 10, 2023

Choose a reason for hiding this comment

oSumAtrIX Oct 10, 2023

Choose a reason for hiding this comment

validcube left a comment

Choose a reason for hiding this comment

KobeW50 commented Sep 24, 2023

PalmDevs commented Sep 24, 2023 • edited Loading

PalmDevs commented Sep 24, 2023

KobeW50 commented Sep 24, 2023 • edited Loading

PalmDevs commented Sep 24, 2023

KobeW50 commented Sep 24, 2023

PalmDevs commented Sep 24, 2023

KobeW50 commented Sep 24, 2023

KobeW50 commented Sep 24, 2023

PalmDevs commented Sep 25, 2023

oSumAtrIX commented Sep 25, 2023

PalmDevs commented Sep 25, 2023

KobeW50 commented Sep 26, 2023 • edited Loading

KobeW50 commented Sep 26, 2023 • edited Loading

Ushie commented Oct 13, 2023 • edited Loading

KobeW50 commented Oct 13, 2023

PalmDevs left a comment

Choose a reason for hiding this comment

KobeW50 commented Oct 13, 2023

PalmDevs commented Oct 13, 2023

KobeW50 commented Oct 13, 2023 • edited Loading

PalmDevs commented Oct 13, 2023

KobeW50 commented Oct 13, 2023 • edited Loading

oSumAtrIX commented Oct 13, 2023

KobeW50 commented Oct 15, 2023 • edited Loading

KobeW50 commented Oct 15, 2023

PalmDevs left a comment

Choose a reason for hiding this comment

PalmDevs left a comment

Choose a reason for hiding this comment

KobeW50 commented Sep 24, 2023 •

edited

Loading

KobeW50 Oct 4, 2023 •

edited

Loading

PalmDevs commented Sep 24, 2023 •

edited

Loading

KobeW50 commented Sep 24, 2023 •

edited

Loading

KobeW50 commented Sep 26, 2023 •

edited

Loading

KobeW50 commented Sep 26, 2023 •

edited

Loading

Ushie commented Oct 13, 2023 •

edited

Loading

KobeW50 commented Oct 13, 2023 •

edited

Loading

KobeW50 commented Oct 13, 2023 •

edited

Loading

KobeW50 commented Oct 15, 2023 •

edited

Loading