Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve manager settings order #1296

Closed
4 tasks done
KobeW50 opened this issue Sep 22, 2023 · 9 comments · Fixed by #1307 or #1384
Closed
4 tasks done

feat: Improve manager settings order #1296

KobeW50 opened this issue Sep 22, 2023 · 9 comments · Fixed by #1307 or #1384
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Sep 22, 2023

Feature description

There are several things that should be changed in the settings:

  1. The 'Team' section should be moved to the bottom, near the 'About' section. It is out of place being in middle of configurable settings. And it is conventionally at the bottom or top in similar projects

  2. The 'Import/Export' section should be renamed. Maybe 'Files' is an appropriate category name. It also should not be alphabetically sorted. This is so suggestions 3-7 would fit into the category and be ordered intuitively.

  3. The 'Regenerate keystore' option should be moved to the 'Import/Export keystore' options.

  4. The 'Reset patches' option should be moved to the 'Import/Export patches selection' options.

  5. The 'Logs' option should be moved to the 'Import/Export' (aka 'Files') section. The 'Info' section would be removed.

  6. The 'Delete logs' option should be moved next to the 'Logs' option in the 'Import/Export' (aka 'Files') section.

  7. The 'Delete temporary files' option should be moved to the 'Import/Export' (aka 'Files') section.

All these changes are likely difficult to visualize so here is how it would look

Advanced

  • API URL
  • Sources
  • Auto update patches
  • Enable changing selection
  • Experimental universal patches support
  • Experimental patches support

Files

  • Export patches selection
  • Import patches selection
  • Reset patches selection
  • Export keystore
  • Import keystore
  • Regenerate keystore
  • Share logs
  • Delete logs
  • Delete temporary files

Team

  • Contributors
  • Socials

About

  • etc

Motivation

The manager settings are currently organized poorly.

Additional context

The 'Logs' options should be renamed to 'Share logs', but ill open a separate issue for that and another minor naming issues.

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@KobeW50 KobeW50 added the Feature request Requesting a new feature that's not implemented yet label Sep 22, 2023
@KobeW50
Copy link
Contributor Author

KobeW50 commented Sep 22, 2023

Screenshot_20230922_120351_ReVanced Manager.jpg

And re-order the files section so the related things are next to eachother

@validcube
Copy link
Member

cc: @PalmDevs

@Ushie
Copy link
Member

Ushie commented Sep 22, 2023

I personally believe this is one of the things that can be left as is until the release of ReVanced Manager rewrite in Jetpack Compose, as settings are completely redone there already

@KobeW50
Copy link
Contributor Author

KobeW50 commented Sep 22, 2023

I personally believe this is one of the things that can be left as is until the release of ReVanced Manager rewrite in Jetpack Compose, as settings are completely redone there already

Would it be impossible for me (a total noob) to figure out how to do it and pr?

@oSumAtrIX
Copy link
Member

Can't know until you try :)

@Ushie
Copy link
Member

Ushie commented Sep 22, 2023

Shouldn't be very complicated, but let's wait for Palm to approve the suggestion first

@PalmDevs
Copy link
Member

I think it'd make more sense if it was

Appearance

Theme
Material You

Advanced

Auto update patches
Allow changing patch selection
Allow experimental patches
Show universal patches
Sources
API URL

Import & export

Export patch selection
Import patch selection
Reset patch selection
Export keystore
Import keystore
Regenerate keystore

Debugging

Share logs
Clear logs
Delete temporary files

(device model info)

@KobeW50
Copy link
Contributor Author

KobeW50 commented Sep 24, 2023

I think it'd make more sense if it was

Appearance

Theme
Material You

Advanced

Auto update patches
Allow changing patch selection
Allow experimental patches
Show universal patches
Sources
API URL

Import & export

Export patch selection
Import patch selection
Reset patch selection
Export keystore
Import keystore
Regenerate keystore

Debugging

Share logs
Clear logs
Delete temporary files

(device model info)

This organization and naming looks good.

Should the 'Team' category be at the very top or below the device info?

@PalmDevs
Copy link
Member

Should the 'Team' category be at the very top or below the device info?

I think above the Debugging section.

@validcube validcube linked a pull request Sep 24, 2023 that will close this issue
@validcube validcube linked a pull request Oct 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants