Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent settings option name and description #1297

Closed
4 tasks done
KobeW50 opened this issue Sep 22, 2023 · 2 comments · Fixed by #1307 or #1384
Closed
4 tasks done

Inconsistent settings option name and description #1297

KobeW50 opened this issue Sep 22, 2023 · 2 comments · Fixed by #1307 or #1384
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Sep 22, 2023

Bug description

  1. The 'Logs' setting option should be renamed to 'Share logs'. All other options in the Manager settings use a verb to explain what the option does.

  2. The 'Reset patches' option should be renamed to 'Reset patch selection' to be consistent and informative as the 'Export/Import patch selection' options.

  3. The 'Enable changing selection' should be renamed to 'Enable changing patch selection' or to 'Custom patch selection' so it informs what it does without forcing the user to read the description.

  4. The descriptions for the 'Delete logs' option and the 'Logs' option should refer to the manager as the "ReVanced Manager". This convention is already used in the description of the 'Auto update patches' toggle description.

Screenshot_20230922_124951_ReVanced Manager.jpg

Screenshot_20230922_125011_ReVanced Manager.jpg

Version of ReVanced Manager and version & name of application you tried to patch

1.10.2

Installation type

None

Device logs

NA

Patcher logs

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@KobeW50 KobeW50 added the Bug report Something isn't working label Sep 22, 2023
@KobeW50
Copy link
Contributor Author

KobeW50 commented Sep 22, 2023

I can pr for this

@KobeW50
Copy link
Contributor Author

KobeW50 commented Sep 24, 2023

This comment from palm is also related. These names are good too

#1296 (comment)

@validcube validcube linked a pull request Sep 24, 2023 that will close this issue
@validcube validcube linked a pull request Oct 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant