boards/stm32f429i-disc1: add initial support #8868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Platform: ARM
aabadie
force-pushed
the
pr/boards/stm32f429i-disc1
branch
from
ad5c959
to
e96f3ff
Compare
|
Can we finish first #8475 before adding more ST boards? |
|
Also, can this board/CPU be tested for xtimer backoff issues (#8807) |
This was referenced Apr 3, 2018
|
just a side question here : |
dylad
reviewed
Apr 9, 2018
| #define LED0_PIN GPIO_PIN(PORT_G, 13) | ||
| #define LED1_PIN GPIO_PIN(PORT_G, 14) | ||
| #define LED2_PIN GPIO_PIN(PORT_B, 13) | ||
| #define LED3_PIN GPIO_PIN(PORT_C, 5) |
There was a problem hiding this comment.
I'm wondering if LED2 & LED3 should be declared, there are related to USB OTG hardware right ?
There was a problem hiding this comment.
You are right, the datasheet is not calling them user LEDs by the way, I'll remove them.
|
I ran a few tests and the board was working fine. I hope I'll be able to run some test with #8623 soon ! |
aabadie
force-pushed
the
pr/boards/stm32f429i-disc1
branch
from
e96f3ff
to
00c5e7f
Compare
|
This looks good, I'll try to test the screen whenever I find some times :) |
It works with #8807 |
aabadie
force-pushed
the
pr/boards/stm32f429i-disc1
branch
from
00c5e7f
to
5c369a8
Compare
aabadie
force-pushed
the
pr/boards/stm32f429i-disc1
branch
2 times, most recently
from
be05a71
to
cf58784
Compare
aabadie
force-pushed
the
pr/boards/stm32f429i-disc1
branch
from
cf58784
to
aa7fad6
Compare
astralien3000
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a very basic support for the STM32F429I-DISC1 board.
This boards embeds an ILI9341 display and could be used with #8623 (not tested yet though).
Only one uart, timer and spi are configured for the moment.
Issues/PRs references
None