-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nucleo-f4xx: increase xtimer backoff to 8 for F4 family #8807
Conversation
Please add on the first message of this PR the already tested boards to see if it doesn't break anything. Still, I'm not convinced this is a good approach to solve this problem, but it's what we have now. Also, we could add to this PR other cases if needed. So please report other boards experiencing this behaviour by running tests/xtimer_usleep_short and if it fails, post at which time it failed. |
Added nucleo-f303ze (e.g. nucleo144-f303) because it's also affected by the change and thus it should be checked as well. |
Added nucleo-f401 to test, also affected and I'm curious whether it requires the same value of 7 as well. Board is on my desk so @kYc0o feel free to grab it tomorrow if I forgot about this. :) |
Tested on F401 and it needs a backoff of 8, changed in my last commit. |
Grepping through the currently supported boards we have the following boards using a stm32f4 CPU:
Preferably I would like to have them all checked for this problem. But I also don't see a huge problem with merging this and leaving the list for an issue. Only thing I'm afraid of then is that the issue will silently die |
@bergzand I added the boards you found to the main description. |
I tested this one on the nucleo boards I have with me (missing nucleo-f411, f446 and f413). For the others (f4v1, stm32f4discovery, etc), this is out of the scope of this PR I think. But I don't say it's not worth checking them as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
80% ACK
@kYc0o, can you squash this one ? I think it can be merged. |
Just tested on stm32f4discovery, it works, I'll squash and this should be ready. |
All green, so let's go |
Contribution description
XTIMER_BACKOFF
is defined with a very low value which fails at 7us for xtimer_sleep on the F4 nucleo family.This PR increases it to 8 which makes all tests pass.
Tested on:
Issues/PRs references
#7347