Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nucleo-f4xx: increase xtimer backoff to 8 for F4 family #8807

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

kYc0o
Copy link
Contributor

@kYc0o kYc0o commented Mar 20, 2018

Contribution description

XTIMER_BACKOFF is defined with a very low value which fails at 7us for xtimer_sleep on the F4 nucleo family.

This PR increases it to 8 which makes all tests pass.

Tested on:

  • f4vi1
  • msbiot
  • nucleo-f401
  • nucleo-f446
  • nucleo-f303ze
  • nucleo-f410
  • nucleo-f411
  • nucleo144-f412
  • nucleo144-f413
  • nucleo144-f429
  • nucleo144-f446
  • stm32f4discovery

Issues/PRs references

#7347

@kYc0o kYc0o added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: timers Area: timer subsystems labels Mar 20, 2018
@kYc0o kYc0o added this to the Release 2018.04 milestone Mar 20, 2018
@kYc0o
Copy link
Contributor Author

kYc0o commented Mar 20, 2018

Please add on the first message of this PR the already tested boards to see if it doesn't break anything. Still, I'm not convinced this is a good approach to solve this problem, but it's what we have now.

Also, we could add to this PR other cases if needed. So please report other boards experiencing this behaviour by running tests/xtimer_usleep_short and if it fails, post at which time it failed.

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 20, 2018
@aabadie
Copy link
Contributor

aabadie commented Mar 20, 2018

Added nucleo-f303ze (e.g. nucleo144-f303) because it's also affected by the change and thus it should be checked as well.

@bergzand
Copy link
Member

Added nucleo-f401 to test, also affected and I'm curious whether it requires the same value of 7 as well. Board is on my desk so @kYc0o feel free to grab it tomorrow if I forgot about this. :)

@kYc0o
Copy link
Contributor Author

kYc0o commented Mar 21, 2018

Tested on F401 and it needs a backoff of 8, changed in my last commit.

@bergzand
Copy link
Member

Grepping through the currently supported boards we have the following boards using a stm32f4 CPU:

  • f4vi1
  • msbiot
  • nucleo-f401
  • nucleo-f410
  • nucleo-f411
  • nucleo-f446
  • nucleo144-f412
  • nucleo144-f413
  • nucleo144-f429
  • nucleo144-f446
  • stm32f4discovery

Preferably I would like to have them all checked for this problem. But I also don't see a huge problem with merging this and leaving the list for an issue. Only thing I'm afraid of then is that the issue will silently die

@kYc0o
Copy link
Contributor Author

kYc0o commented Apr 3, 2018

@bergzand I added the boards you found to the main description.

@aabadie
Copy link
Contributor

aabadie commented Apr 3, 2018

I tested this one on the nucleo boards I have with me (missing nucleo-f411, f446 and f413). For the others (f4v1, stm32f4discovery, etc), this is out of the scope of this PR I think. But I don't say it's not worth checking them as well.

Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

80% ACK

@aabadie
Copy link
Contributor

aabadie commented Apr 10, 2018

@kYc0o, can you squash this one ? I think it can be merged.

@kYc0o
Copy link
Contributor Author

kYc0o commented Apr 10, 2018

Just tested on stm32f4discovery, it works, I'll squash and this should be ready.

@aabadie
Copy link
Contributor

aabadie commented Apr 10, 2018

All green, so let's go

@aabadie aabadie merged commit 479ee51 into RIOT-OS:master Apr 10, 2018
@cladmi cladmi changed the title nucleo-f4xx: increase xtimer backoff to 7 for F4 family nucleo-f4xx: increase xtimer backoff to 8 for F4 family Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants