Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/nucleo-f429zi: fix spi divtable #8870

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 3, 2018

Contribution description

While working on #8868, I realized that the spi configuration of the nucleo-f429zi was incorrect (since they share the same MCU model): the APB1/APB2 values used to generate the div_table are obviously wrong.

This PR fixes that.

Issues/PRs references

None

@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Apr 3, 2018
Copy link
Member

@vincent-d vincent-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be also fixed by #8549 in a more generic way ;)
This anyway seems obvious. Untested ACK, I don't have that board.

@vincent-d vincent-d merged commit e7b0ace into RIOT-OS:master Apr 4, 2018
@aabadie aabadie deleted the pr/boards/nucleo-f429zi_spi_fix branch June 1, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants