Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/isr_yield_higher: adapt TEST_TIME to start-up time #12539

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

fjmolinas
Copy link
Contributor

Contribution description

This commit is cherry-picked from #12461. The current test depends on start-ups time since TEST_TIME is absolute, this can cause issue if there is a delayed start, eg. a sync mechanism is used in the test (see #12461). This makes TEST_TIME related checks depend on start_time.

Testing procedure

Test still passes.

make -C tests/isr_yield_higher/ BOARD=samr21-xpro flash test -j3

Issues/PRs references

#12461 depends on this.

@fjmolinas fjmolinas added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Oct 22, 2019
@fjmolinas fjmolinas force-pushed the pr_isr_yield_relative_time branch 2 times, most recently from d16cf08 to 1c62ee8 Compare October 22, 2019 07:43
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 22, 2019
@fjmolinas fjmolinas removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 22, 2019
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 22, 2019
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit e2049cc into RIOT-OS:master Oct 22, 2019
@fjmolinas fjmolinas deleted the pr_isr_yield_relative_time branch December 1, 2019 14:17
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants