Make optimize_1q_gates U and P aware #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimize 1q gates pass currently only operates on u1, u2, u3 (or a subset of that), however the u gate is interchangeable with the u3 gate and the pass can be run if there is a u in the basis just as easily as if it were a u3. This comes up for backends with overcomplete basis sets, like Aer, which can have u and u3 in the same circuit. The optimization pass will not simplify those gates despite it being possible.
kdk
reviewed
Nov 24, 2020
Just as U and U3 are interchangeable, U1 and P are also interchangeable. This commit makes the same change to the Optimize1QGates pass done earlier for supporting U for U1 and P so that if will work for a basis where P is used instead of U1.
mtreinish
changed the title
kdk
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
Changes look good. I wonder though if we still need Optimize1qGates now that we have Optimize1qDecompositions. As far as I know, the only missing feature from Optimize1qDecompositions is the U3->{U2,U1} simplification, but I don't see why this couldn't be added to the OneQubitEulerDecomposer.
mtreinish
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2021
* Make optimize_1q_gates U aware The optimize 1q gates pass currently only operates on u1, u2, u3 (or a subset of that), however the u gate is interchangeable with the u3 gate and the pass can be run if there is a u in the basis just as easily as if it were a u3. This comes up for backends with overcomplete basis sets, like Aer, which can have u and u3 in the same circuit. The optimization pass will not simplify those gates despite it being possible. * Make Optimize1QGates Phase gate aware too Just as U and U3 are interchangeable, U1 and P are also interchangeable. This commit makes the same change to the Optimize1QGates pass done earlier for supporting U for U1 and P so that if will work for a basis where P is used instead of U1. * Fix lint Co-authored-by: Kevin Krsulich <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9e6a016)
mergify bot
added a commit
that referenced
this pull request
Jan 19, 2021
* Make optimize_1q_gates U aware The optimize 1q gates pass currently only operates on u1, u2, u3 (or a subset of that), however the u gate is interchangeable with the u3 gate and the pass can be run if there is a u in the basis just as easily as if it were a u3. This comes up for backends with overcomplete basis sets, like Aer, which can have u and u3 in the same circuit. The optimization pass will not simplify those gates despite it being possible. * Make Optimize1QGates Phase gate aware too Just as U and U3 are interchangeable, U1 and P are also interchangeable. This commit makes the same change to the Optimize1QGates pass done earlier for supporting U for U1 and P so that if will work for a basis where P is used instead of U1. * Fix lint Co-authored-by: Kevin Krsulich <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9e6a016) Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The optimize 1q gates pass currently only operates on u1, u2, u3 (or a
subset of that), however the u gate is interchangeable with the u3 gate
and the pass can be run if there is a u in the basis just as easily as
if it were a u3. This comes up for backends with over complete basis
sets, like Aer, which can have u and u3 in the same circuit. The
optimization pass will not simplify those gates despite it being
possible.
Details and comments