-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make optimize_1q_gates U and P aware #5429
Merged
Merged
Commits on Nov 24, 2020
-
Make optimize_1q_gates U aware
The optimize 1q gates pass currently only operates on u1, u2, u3 (or a subset of that), however the u gate is interchangeable with the u3 gate and the pass can be run if there is a u in the basis just as easily as if it were a u3. This comes up for backends with overcomplete basis sets, like Aer, which can have u and u3 in the same circuit. The optimization pass will not simplify those gates despite it being possible.
Configuration menu - View commit details
-
Copy full SHA for ee87525 - Browse repository at this point
Copy the full SHA ee87525View commit details
Commits on Nov 25, 2020
-
Make Optimize1QGates Phase gate aware too
Just as U and U3 are interchangeable, U1 and P are also interchangeable. This commit makes the same change to the Optimize1QGates pass done earlier for supporting U for U1 and P so that if will work for a basis where P is used instead of U1.
Configuration menu - View commit details
-
Copy full SHA for e37928c - Browse repository at this point
Copy the full SHA e37928cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c6d648 - Browse repository at this point
Copy the full SHA 9c6d648View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6065ef6 - Browse repository at this point
Copy the full SHA 6065ef6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 843d97f - Browse repository at this point
Copy the full SHA 843d97fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0929a10 - Browse repository at this point
Copy the full SHA 0929a10View commit details
Commits on Nov 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6988dfb - Browse repository at this point
Copy the full SHA 6988dfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for df542fe - Browse repository at this point
Copy the full SHA df542feView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.