pyo3-build-config: add test for parsing sysconfigdata #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
test-parse-sysconfigdata
branch
5 times, most recently
from
648882d to
a0e76e2
Compare
davidhewitt
force-pushed
the
test-parse-sysconfigdata
branch
from
a0e76e2 to
4a6ea17
Compare
|
Well, it's not perfect but it does add coverage to a reasonable chunk of code, so I'll proceed to merge this. |
messense
reviewed
Oct 12, 2021
| ) | ||
| })?; | ||
| script += r#" | ||
| print("version_major", build_time_vars["VERSION"][0]) # 3 | ||
| print("version_minor", build_time_vars["VERSION"][2]) # E.g., 8 | ||
| print("version", build_time_vars["VERSION"]) |
There was a problem hiding this comment.
Looks like this change also fixed Python 3.10 cross compiling issue, can we backport this to pyo3 0.14.x?
See https://github.com/PyO3/maturin/pull/646/checks?check_run_id=3870744693
There was a problem hiding this comment.
Hmm I'd rather try to release PyO3 0.15 in the next couple of weeks - it would be nice to make an "official" milestone which supports Python 3.10 and I don't think there's anything blocking the release.
chrisburr
added a commit
to regro-cf-autotick-bot/cryptography-feedstock
that referenced
this pull request
Nov 4, 2021
chrisburr
added a commit
to regro-cf-autotick-bot/cryptography-feedstock
that referenced
this pull request
Nov 4, 2021
h-vetinari
added a commit
to h-vetinari/tokenizers-feedstock
that referenced
this pull request
Mar 21, 2022
h-vetinari
added a commit
to h-vetinari/tokenizers-feedstock
that referenced
this pull request
Mar 21, 2022
h-vetinari
added a commit
to h-vetinari/tokenizers-feedstock
that referenced
this pull request
Mar 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get some extra test coverage...