Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python310 #81

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python310.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1413140670, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented Nov 2, 2021

Failing with:

    --- stderr
    error: Could not find either libpython.so or _sysconfigdata*.py in /Users/runner/miniforge3/conda-bld/cryptography_1635874618838/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.1/site-packages/../
  warning: build failed, waiting for other jobs to finish...
  error: build failed

@h-vetinari
Copy link
Member

Cancelled the drone build until we figure out the other errors.

@h-vetinari
Copy link
Member

Might be related to conda-forge/python-feedstock#511, resp. maybe that PR was not 100% complete?

@h-vetinari
Copy link
Member

Ah, I hadn't realised that this only concerns osx-arm. I chased down the seemingly related line

    - find $PYO3_CROSS_LIB_DIR -name "_sysconfigdata*.py" -not -name "${_CONDA_PYTHON_SYSCONFIGDATA_NAME_BACKUP}.py" -type f -exec rm -f {} +

to #64, and actually there's a comment from Isuru that these can be removed. Let's try that.

@h-vetinari h-vetinari force-pushed the rebuild-python310-0-1_h5b5ed2 branch from 45af902 to 6cb38e6 Compare November 4, 2021 03:26
@h-vetinari
Copy link
Member

Ah, now we definitely seem to be hitting something related to conda-forge/python-feedstock#511:

    --- stderr
    error: cannot set a minimum Python version 3.6 higher than the interpreter version 3.1 (the minimum Python version is implied by the abi3-py36 feature)

This is only on osx-arm, and I'm not sure where & how the wrong version is being picked up. @chrisburr @isuruf, any thoughts?

@chrisburr
Copy link
Member

It's a bug in pyo3: PyO3/pyo3#1847 (comment)

@chrisburr chrisburr force-pushed the rebuild-python310-0-1_h5b5ed2 branch from f811739 to 4f84d62 Compare November 4, 2021 07:56
@h-vetinari
Copy link
Member

Thanks a lot for the help @chrisburr & @isuruf! :)

Putting an automerge on this.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Nov 4, 2021
@chrisburr chrisburr removed the automerge Merge the PR when CI passes label Nov 4, 2021
@chrisburr
Copy link
Member

I've removed automerge as aarch64 isn't being build due to the drone issues...

@h-vetinari
Copy link
Member

I've removed automerge as aarch64 isn't being build due to the drone issues...

We're already cross-compiling (well, emulating) for PPC - do you want to do the same for aarch?

@beckermr beckermr added the bot-rerun Instruct the bot to retry the PR label Nov 4, 2021
@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/1420874577

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python310-0-1_h5b5ed2 branch November 4, 2021 10:50
@h-vetinari
Copy link
Member

@beckermr
Why did you add a re-run? This PR was green and ready...?

@h-vetinari
Copy link
Member

I reopened this in #82. I'd be ready to merge it, but will wait for comment about why you restarted.

@beckermr
Copy link
Member

beckermr commented Nov 4, 2021

Sorry! We had some trouble with the bot and I added the label to this pr wrongly. Merge whenever you are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants