Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for Python 3.10 #71

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Conversation

messense
Copy link
Contributor

No description provided.

@messense
Copy link
Contributor Author

Blocked by PyO3/maturin#646 which is blocked by PyO3/pyo3#1847 (comment) 🤪

@milesgranger
Copy link
Owner

Thanks @messense!

@messense
Copy link
Contributor Author

messense commented Oct 25, 2021

Encountered an exception when using the pyo3 release-0.15 branch: SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats, @davidhewitt do you know why?

Edit: looks like it's not pyo3(cramjam) but zstd package.

@milesgranger
Copy link
Owner

milesgranger commented Oct 25, 2021

Yes, zstd is pinned to 1.4.5.1 in benchmark-requirements.txt and I can reproduce locally with Python 3.10

Successfully installed zstd-1.4.5.1
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
root@fd1f3ba1dce3:/# bpython
bpython version 0.21 on top of Python 3.10.0 /usr/local/bin/python

import zstd
zstd.decompress(zstd.compress(b'byes'))
Traceback (most recent call last):
File "", line 1, in
zstd.decompress(zstd.compress(b'byes'))
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

But the latest 1.5.0.2 works fine.

@messense messense force-pushed the patch-1 branch 8 times, most recently from 71dab58 to 3bb1bf9 Compare November 6, 2021 13:13
@messense
Copy link
Contributor Author

messense commented Nov 6, 2021

Hit pypa/pip#10151

@messense messense force-pushed the patch-1 branch 4 times, most recently from 9cc389b to 4fa7a8f Compare November 6, 2021 14:09
@messense
Copy link
Contributor Author

messense commented Nov 6, 2021

@milesgranger This is ready now.

@milesgranger milesgranger merged commit 026e38a into milesgranger:master Nov 6, 2021
@milesgranger
Copy link
Owner

This took a bit of extra work on your part, thank you! 💯

@messense messense deleted the patch-1 branch November 7, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants