Fix Funnel rendering on dashboards #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
reviewed
Mar 12, 2021
| const { results: stepsResult, resultsLoading: funnelLoading } = useValues(logic) | ||
| const { loadResults: loadFunnel } = useActions(logic) | ||
| const { filters } = useValues(funnelLogic({ filters: defaultFilters })) | ||
| const { filters } = useValues(logic) |
There was a problem hiding this comment.
nit but I think you can just add filters to the unpack in line 23
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes this #3574
Dashboards that had two types of funnel displays were not rendering properly. Only one or the other was rendering.
Did some digging and saw that in the component itself we were using two logics – one keyed by the item and one not. That was causing filters to be cached and shared across since a key wasn't being passed in to the filter query.
Solution:
Checklist