Skip to content

Commit

Permalink
Fix Funnel rendering on dashboards (#3641)
Browse files Browse the repository at this point in the history
* use the same logic within a component instance

* cleanup value unpack

Co-authored-by: kunal <[email protected]>
  • Loading branch information
kpthatsme and kunal authored Mar 12, 2021
1 parent fa5da57 commit 4210717
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions frontend/src/scenes/funnels/FunnelViz.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ export function FunnelViz({
}) {
const container = useRef(null)
const [steps, setSteps] = useState(stepsParam)
const logic = funnelLogic({ dashboardItemId, cachedResults })
const { results: stepsResult, resultsLoading: funnelLoading } = useValues(logic)
const logic = funnelLogic({ dashboardItemId, cachedResults, filters: defaultFilters })
const { results: stepsResult, resultsLoading: funnelLoading, filters } = useValues(logic)
const { loadResults: loadFunnel } = useActions(logic)
const { filters } = useValues(funnelLogic({ filters: defaultFilters }))
const [{ fromItem }] = useState(router.values.hashParams)

function buildChart() {
Expand Down

0 comments on commit 4210717

Please sign in to comment.