Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Funnel rendering on dashboards #3641

Merged
merged 2 commits into from
Mar 12, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/scenes/funnels/FunnelViz.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ export function FunnelViz({
}) {
const container = useRef(null)
const [steps, setSteps] = useState(stepsParam)
const logic = funnelLogic({ dashboardItemId, cachedResults })
const logic = funnelLogic({ dashboardItemId, cachedResults, filters: defaultFilters })
const { results: stepsResult, resultsLoading: funnelLoading } = useValues(logic)
const { loadResults: loadFunnel } = useActions(logic)
const { filters } = useValues(funnelLogic({ filters: defaultFilters }))
const { filters } = useValues(logic)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit but I think you can just add filters to the unpack in line 23

const [{ fromItem }] = useState(router.values.hashParams)

function buildChart() {
Expand Down