Fix the FP16 precision problem of add_n. #50129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
liuruyan
force-pushed
the
add_n_develop
branch
from
c309274
to
94ea8a5
Compare
| } | ||
| } | ||
| out[id] = total; | ||
| out[id] = static_cast<T>(total); | ||
| id += blockDim.x * gridDim.x; | ||
| } | ||
| } |
There was a problem hiding this comment.
只改这里应该不够吧？AddNKernel中有一些条件走了其他实现，比如如果是2个tensor，调用eigen库实现的，那里加法也需要提升到fp32计算。
pangengzheng
pushed a commit
to pangengzheng/Paddle
that referenced
this pull request
Feb 2, 2023
Xreki
pushed a commit
to Xreki/Paddle
that referenced
this pull request
Apr 9, 2023
aoyulong
pushed a commit
that referenced
this pull request
Apr 11, 2023
* Fix scale kernel for low precision, cherry pick #50998. * Fix the FP16 precision problem of add_n. (#50129) * Change squared_l2_norm to reuse ReduceKernel, and register fp16 and bf16 kernel, which is cherry pick #48315. * Cherry-pick the fix of MPTypeTrait in KP, which is implemented in #50993. * Cherry-pick the multi-precision support of AdamW for bf16, #48041. * Fix compiling error. * Cherry-pick the fix of CubTensorReduceImpl for bfloat16 in #50993. * Fix unittest. --------- Co-authored-by: liuruyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
Fix the FP16 precision problem of add_n.