Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMID: 33203871 Two nuclear effectors of the rice blast fungus modulate host immunity via transcriptional reprogramming #104

Closed
CuzickA opened this issue Mar 30, 2022 · 43 comments

Comments

@CuzickA
Copy link

CuzickA commented Mar 30, 2022

Curation of this paper may need some new PHIPO terms as the pathogen effector protein is binding to host gene promoter. Therefore will probably need some pathogen protein - host DNA binding terms under PHI molecular function group.

@CuzickA

This comment was marked as resolved.

@smvelasquez
Copy link

@smvelasquez
Copy link

I need new terms: normal localization to the biotrophic interfacial complex (BIC), normal vegetative growth, V8 agar, +9dpi

@smvelasquez

This comment was marked as outdated.

@CuzickA

This comment was marked as duplicate.

@smvelasquez

This comment was marked as duplicate.

@CuzickA

This comment was marked as duplicate.

@CuzickA CuzickA self-assigned this Oct 21, 2022
@CuzickA

This comment was marked as resolved.

@CuzickA CuzickA added the next label Nov 11, 2022
@CuzickA

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@smvelasquez

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@ValWood

This comment was marked as resolved.

@ValWood

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@CuzickA

This comment was marked as resolved.

@ValWood
Copy link

ValWood commented Nov 21, 2022

speckles is quite vague and does not relate to a specific structure. Speckles tend to be a generic terms for inclusion bodies if authors are not sure of the exact structure. I would not annotate this without additional info.

Re

Tricky to know whether to annotate essentially WT protein localization data as a phenotype or a GO CC (or both!).

If it is WT, GO annotation for the cellular component only.
You don't need to make normal locations phenotypes for WT (that is a given).

@ValWood
Copy link

ValWood commented Nov 21, 2022

@ValWood
Copy link

ValWood commented Nov 21, 2022

ideally it would be cytoplasm part_of conidium from fungal anatomy ontology https://www.ebi.ac.uk/ols/ontologies/fao/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FFAO_0000024

@CuzickA
Copy link
Author

CuzickA commented Nov 21, 2022

Thanks @ValWood :-)

I have now used 'edit as text' to add in 'part_of(conidium)', deleted the WT normal location phenotypes in favour of GO and omitted the vague 'speckles' observation.

image

@CuzickA
Copy link
Author

CuzickA commented Nov 21, 2022

Hi @smvelasquez,

We don't need to curate the WT pathogen phenotype controls for normal number of spores here. I will delete these entries.

image

In the case of PHI phenotype annotations we DO curate the WT controls where possible as this makes the PHI phenotype annotations to altered metagenotypes easier to interpret (also using the AE compared_to). I have made a note of this on our Documentation tracker. Do you feel this is information missing from the Help documentation?

@smvelasquez
Copy link

smvelasquez commented Nov 21, 2022 via email

@CuzickA
Copy link
Author

CuzickA commented Nov 22, 2022

Session now checked.
Waiting on loading of PHI-ECO and PHIPO terms.

@CuzickA
Copy link
Author

CuzickA commented Nov 22, 2022

Summary of curation issues and tips to document from this session

  1. Highlight the importance of making a GO BP 'effector-mediated...' annotation where appropriate so enable high level 'effector' term to be displayed in PHI5. https://canto.phi-base.org/docs/phipo_annotation#pathogen_host_interaction_phenotypes
  2. When connecting GO MF to GO BP 'effector-mediated...' use AE 'involved in biological process/part_of' rather than 'has function during/happens_during' (it is a stronger statement than during which is only saying happens at this time). https://canto.phi-base.org/docs/phipo_annotation#pathogen_host_interaction_phenotypes
  3. Make it clear when to make a GO annotation vs a phenotype annotation. Make it clear that some WT annotations can be covered by GO annotations and do not need additional phenotype annotations canto-docs#26
  4. Careful use of terms 'presence of pathogen-associated host lesions' vs 'presence of pathogen-associated host defense induced lesions' and 'presence of host-defense induced lesion by host hypersensitive response'.
  5. No need to curate complementation control expts. It is a given that the author has done these expts.
  6. How to curate 'Transgenic host plant expressing pathogen effector and then inoculated with same WT pathogen' using conditions 'delivery mechanism: pathogen gene expressed by transgenic host', '+ wild type pathogen inoculation'.
  7. It is NOT possible to curate 'Transgenic host plant expressing pathogen effector and then inoculated with a different WT pathogen.'
  8. AE 'penetrance' does not mean penetration of pathogen into host. https://canto.phi-base.org/docs/phipo_annotation#annotation_extensions
  9. Don't curate Pathogen or host phenotype controls. Do curate WT metagenotype controls where possible to aid interpretation of altered metagenotype phenotypes. Check documentation is clear on when to add WT control phenotype annotations canto-docs#27 https://canto.phi-base.org/docs/genotypes#metagenotype_management
  10. Trying to keep genotypes simple. We may need to provide a few example genotypes from different publications.

@CuzickA
Copy link
Author

CuzickA commented Nov 22, 2022

Existing documentation in the main Help document covering the above issues
@smvelasquez, please can you review to see if you think it is adequate

  1. and 2. https://canto.phi-base.org/docs/phipo_annotation#pathogen_host_interaction_phenotypes
    image

8 https://canto.phi-base.org/docs/phipo_annotation#annotation_extensions
image

  1. https://canto.phi-base.org/docs/genotypes#metagenotype_management
    image

Issues 3, 4, 6, 10 could be documented with examples in the FAQ document (to be combined with curation tips document). Issues 5, 7, 9 could be added to a section on 'Information not to curate'.

@smvelasquez
Copy link

@CuzickA I think what you wrote clarifies those points and I do agree with diving the items into FAQ and a new section 'Information not to curate'

@CuzickA
Copy link
Author

CuzickA commented Nov 23, 2022

PHI-ECO and PHIPO terms now loaded so approving session.

Keeping ticket open until 'curations issues' noted above have been fully documented.

@CuzickA
Copy link
Author

CuzickA commented Dec 2, 2022

Added AE 'with host species'

image

I don't think its possible to add GO CC for "biotrophic interfacial complex (BIC)"

Consider adding https://www.ebi.ac.uk/QuickGO/term/GO:0085039

@CuzickA
Copy link
Author

CuzickA commented Dec 2, 2022

Added BIC / hyphal membrane term to GO CC. Reapproved session

image

@CuzickA CuzickA removed the next label Jan 13, 2023
@CuzickA
Copy link
Author

CuzickA commented Jan 13, 2023

Closing ticket for now as session complete and approved. May need to be referred back to when writing up the FAQ document.

@CuzickA CuzickA closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment