Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick #5353 into release-v5.2 #5367

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Dec 13, 2024

Will get into RC.1

Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 6af798f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx enabled auto-merge (squash) December 13, 2024 09:00
Amxx and others added 2 commits December 13, 2024 10:07
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Francisco Giordano <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
@Amxx Amxx force-pushed the chore/cherrypick-v5.2-rc.1 branch from 743ac45 to 3fa7f94 Compare December 13, 2024 09:07
@Amxx Amxx requested a review from a team December 13, 2024 09:40
@Amxx
Copy link
Collaborator Author

Amxx commented Dec 13, 2024

Do not merge until #5371 is merged an cherrypicked

Edit: done

@ernestognw ernestognw disabled auto-merge December 13, 2024 16:21
@Amxx
Copy link
Collaborator Author

Amxx commented Dec 13, 2024

Since we changing an unreleased feature, and there is no Changelog difference between the RC (this is not a patch), I don't think we should have a changelog entry for this.

We'll fix that when we cleanup the changelog, otherwise it will mess up the list of changeset between here and master and it risk showing up again.

@Amxx Amxx requested a review from ernestognw December 16, 2024 08:24
@Amxx Amxx merged commit ab96c48 into OpenZeppelin:release-v5.2 Dec 16, 2024
16 checks passed
@Amxx Amxx deleted the chore/cherrypick-v5.2-rc.1 branch December 16, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants