Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename arrayLengthPointer -> arrayLengthOffset and add changeset #5371

Conversation

ernestognw
Copy link
Member

We'll need a changeset to perform a proper release. Also, I'm amending a mistake while renaming a variable inside decodeBatch

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@ernestognw ernestognw requested a review from Amxx December 13, 2024 16:02
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: ab06461

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx
Copy link
Collaborator

Amxx commented Dec 13, 2024

Before we merge, I like to make sure all the working/naming is good with @frangio
Lets not make one more PR :)

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense because a pointer is absolute and an offset is relative.

@ernestognw ernestognw merged commit 535b54d into OpenZeppelin:master Dec 13, 2024
17 checks passed
Amxx pushed a commit to Amxx/openzeppelin-contracts that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants